Refactor/jira kan 72 환율 및 환전 리팩토링#84
Merged
CryingPerson merged 14 commits intodevelopfrom Apr 8, 2025
Hidden character warning
The head ref may contain hidden characters: "Refactor/JIRA-kan-72-\ud658\uc728-\ubc0f-\ud658\uc804-\ub9ac\ud329\ud1a0\ub9c1"
Merged
Conversation
added 10 commits
April 7, 2025 10:33
…into Refactor/JIRA-kan-72-환율-및-환전-리팩토링
1 task
usingjun
reviewed
Apr 8, 2025
| import java.util.concurrent.Executor; | ||
|
|
||
| @Service | ||
| @RequiredArgsConstructor |
Collaborator
There was a problem hiding this comment.
RequiredArgsConstructor 사용햇는데 생성자 주입 받고있는데 수정부탁드립니다
|
|
||
| exchangeRates = exchangeRepository.findByBaseCurrency(baseCurrency); | ||
| if (!exchangeRates.isEmpty()) { | ||
| return toResponse(baseCurrency, exchangeRates); |
Collaborator
Author
There was a problem hiding this comment.
추후 계속 반복될경우 코드를 빼는 방향으로 가겠습니다.
두번정도는 충분히 괜찮다고 생각합니다.
Si-rauis
approved these changes
Apr 8, 2025
|
|
||
| public ExchangeRateResponse fetchExchangeRates(String baseCurrency) { | ||
| String API_URL = url + baseCurrency; | ||
| String API_URL = "https://v6.exchangerate-api.com/v6/" + authkey + "/latest/" + baseCurrency; |
Collaborator
There was a problem hiding this comment.
global/common 안에 있는 constants 파일에 상수를 보관해서 관리하는게 좋아보입니다!
| @PersistenceContext | ||
| private final EntityManager entityManager; | ||
|
|
||
| private static final long LOCK_KEY = 987654321L; |
Collaborator
There was a problem hiding this comment.
이것도 상수 관리 필드에 옮겨주시면 좋겠습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ 과제 요약
📝 요구 사항과 구현 내용
✅ 피드백 반영사항
💬 PR 포인트 & 궁금한 점
🔗 연관된 이슈