Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build fail on node 18 html-editor #3455

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

minhnhut16
Copy link
Contributor

@minhnhut16 minhnhut16 commented Jul 31, 2024

Description

Recently, I merged this pull request #3306 for custom rich-text editor. But after discuss with BuilderIO team via email, current node version is 18, that causes problem when running npm run build.

I added some lines of code that can fix this problem when building this plugin.

@minhnhut16 minhnhut16 requested a review from a team as a code owner July 31, 2024 10:53
@minhnhut16 minhnhut16 requested review from gustavocodess and removed request for a team July 31, 2024 10:53
Copy link

changeset-bot bot commented Jul 31, 2024

⚠️ No Changeset found

Latest commit: 03e5e85

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant