Skip to content

dependencies on dev versions are not strict enough due to breaking changes #467

Description

@moodymudskipper

I had this:

library(blockr)                                                                                                                                                            
  +                                                                                                                                                                                          
  + run_app(                                                                                                                                                                                     
  +   blocks = c(                                                                                                                                                                              
  +     a = new_dataset_block("iris")                                                                                                                                                          
  +   )                                                                                                                                                                                      
  + )                                                                                                                                                                                        
  ── Attaching blockr packages ─────────────────────────────────────────────────────────────────────────────────────────────────────── blockr 0.1.1 ──                                       
  ✔ blockr.core   0.1.2     ✔ blockr.dplyr  0.1.0                                                                                                                                            
  ✔ blockr.dag    0.1.0     ✔ blockr.ggplot 0.1.0                                                                                                                                            
  ✔ blockr.dock   0.1.0     ✔ blockr.io     0.1.0                                                                                                                                            
  Warning messages:                                                                                                                                                                          
  1: package ‘blockr.dock’ was built under R version 4.4.3                                                                                                                                   
  2: package ‘blockr.dag’ was built under R version 4.4.3                                                                                                                                    
  3: package ‘blockr.dplyr’ was built under R version 4.4.3                                                                                                                                  
  4: package ‘blockr.ggplot’ was built under R version 4.4.3                                                                                                                                 
  5: package ‘blockr.io’ was built under R version 4.4.3                                                                                                                                     
  Warning: Error in UseMethod: no applicable method for 'as_blocks' applied to an object of class "character"                                                                                
    88: as_blocks                                                                                                                                                                            
    84: block_metadata                                                                                                                                                                       
    83: blks_metadata                                                                                                                                                                        
    82: edit_ui                                                                                                                                                                              
    79: <Anonymous>                                                                                                                                                                          
    78: mapply                                                                                                                                                                               
    77: Map                                                                                                                                                                                  
    76: map                                                                                                                                                                                  
    75: block_ui.dock_board                                                                                                                                                                  
    66: board_ui.dock_board                                                                                                                                                                  
    63: blockr_app_ui.dock_board                                                                                                                                                             
    60: ui                                                                                                                                                                                   
     3: runApp                                                                                                                                                                               
     2: print.shiny.appobj                                                                                                                                                                   
     1: <Anonymous>                                                                                                                                                                          
                                                                                                                                                                                             
                                                                                                                                                                                             
                                                                                                                                                                                             
  Listening on http://127.0.0.1:6438 

It seems that it might have been triggered by the package requiring blockr.dock 0.1.1 from github, so github version fails with CRAN dependency.

After update I get:

> library(blockr)
+ 
+ run_app(
+   blocks = c(
+     a = new_dataset_block("iris")
+   )
+ )
── Attaching blockr package
✔ blockr.core   0.1.2     ✔ blockr.dplyr  0.1.0
✔ blockr.dag    0.1.0     ✔ blockr.ggplot 0.1.0
✔ blockr.dock   0.1.1     ✔ blockr.io     0.1.0
Warning messages:
1: package ‘blockr.dag’ was built under R version 4.4.3 
2: package ‘blockr.dplyr’ was built under R version 4.4.3 
3: package ‘blockr.ggplot’ was built under R version 4.4.3 
4: package ‘blockr.io’ was built under R version 4.4.3 
Warning: Error in : 'add_link_action' is not an exported object from 'namespace:blockr.dock'
  79: new_context_menu_entry
  78: context_menu_items.dag_extension
  76: lapply
  75: context_menu_items.list
  73: context_menu_items.dock_extensions
  71: context_menu_items.dock_board
  69: module
  64: callModule
  63: moduleServer
  62: <Anonymous>
  58: FUN
  57: lapply
  56: <Anonymous>
  54: module
  49: callModule
  48: moduleServer
  47: board_server.board
  45: blockr_app_server.dock_board
  42: server
   3: runApp
   2: print.shiny.appobj
   1: <Anonymous>
Error : 'add_link_action' is not an exported object from 'namespace:blockr.dock'

Which seems to mean that the blockr.dag package must be updated too

After updating this I get:

> pak::pak("BristolMyersSquibb/blockr.dag")
✔ Loading metadata database ... done                                      
                                                                            
→ Will update 1 package.
→ The package (0 B) is cached.
+ blockr.dag 0.1.0 → 0.1.2.9000 👷🏼‍♂️🔧 (GitHub: cad85f5)

! blockr.dag is loaded in the current R session, you probably need to restart R after
the installation.

? Do you want to continue (Y/n) 
Y
ℹ No downloads are needed, 1 pkg is cached
✔ Got blockr.dag 0.1.2.9000 (source) (228.43 kB)
ℹ Packaging blockr.dag 0.1.2.9000
✔ Packaged blockr.dag 0.1.2.9000 (1.2s)                              
ℹ Building blockr.dag 0.1.2.9000                                     
✔ Built blockr.dag 0.1.2.9000 (1.5s)                                 
✔ Installed blockr.dag 0.1.2.9000 (github::BristolMyersSquibb/blockr.dag@cad85f5) (23ms)
✔ 1 pkg + 55 deps: kept 55, upd 1, dld 1 (NA B) [30s]                  
R 4.4.0 exited (preparing for restart)
R 4.4.0 restarted.
> library(blockr)
+ 
+ run_app(
+   blocks = c(
+     a = new_dataset_block("iris")
+   )
+ )
── Attaching blockr packages ────────────────────────────────────────── blockr 0.1.1 ──
✔ blockr.core   0.1.2          ✔ blockr.dplyr  0.1.0     
✔ blockr.dag    0.1.2.9000     ✔ blockr.ggplot 0.1.0     
✔ blockr.dock   0.1.1          ✔ blockr.io     0.1.0     
Warning messages:
1: package ‘blockr.dplyr’ was built under R version 4.4.3 
2: package ‘blockr.ggplot’ was built under R version 4.4.3 
3: package ‘blockr.io’ was built under R version 4.4.3 
Warning: package ‘shiny’ was built under R version 4.4.3
Warning: Error in g6_output_port: could not find function "g6_output_port"
  77: <Anonymous>
  76: mapply
  75: Map
  74: map
  73: g6_nodes_from_blocks
  72: g6_data_from_board
  71: g6_from_board
  70: init_g6
  69: module
  64: callModule
  63: moduleServer
  62: <Anonymous>
  58: FUN
  57: lapply
  56: <Anonymous>
  54: module
  49: callModule
  48: moduleServer
  47: board_server.board
  45: blockr_app_server.dock_board
  42: server
   3: runApp
   2: print.shiny.appobj
   1: <Anonymous>
Error in g6_output_port(key = out_id, label = NULL, arity = Inf, visibility = "hover",  : 
  could not find function "g6_output_port"

This seemed to indicate that my g6R package was outdated too : pak::pak("cynkra/g6R")

These make the development version hard to use for regular users, I believe this would be solved by adding the proper minimal versions and remote dependencies

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions