Bring the warning amber and the dock's header tools to 3:1 - #61
Merged
Merged
Conversation
At rest the "..." took border-strong, which the dark scheme keeps faint for lines: 1.4:1 on bg-surface, where the icon all but vanished. The tools now take text-disabled at rest and text-muted on hover.
The dot's fills point straight at the meaning tokens, which block_status_style() names next to their light values, so blockr.dock declares no status tokens and the DAG draws from the same spec.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
The dock header's tools were a step quieter than other tools, in text-disabled: 2.5:1 on white, under the 3:1 an active control's icon needs (WCAG 1.4.11), and a colour the token table keeps for disabled controls. They now look like every other tool. The warning border was amber-500, 2.2:1 on white. The unset and waiting status dots are drawn in it, and so is a required empty field's edge. It is now amber-600, #d97706, a new step of the ramp, at 3.2:1 on white. Amber-700, the warning text, would clear 3:1 too, but it is as dark as the danger red (1.04:1 between them), so an unset dot and a failed one would differ by hue alone. Dark mode is unchanged. A test holds icons and status borders to 3:1 on bg-surface in both schemes, the non-text half of what the Chrome check's axe covers for text. It fails on the old amber. The spec also names block_status_badge(), the function the DAG calls, where it said block_status_style(), the dock's internal helper.
nbenn
changed the title
nbenn
added a commit
to BristolMyersSquibb/blockr.dock
that referenced
this pull request
Sep 30, 2026
The header's tools rested in text-disabled, 2.5:1 on white: under the 3:1 an active control's icon needs (WCAG 1.4.11), and the colour blockr.ui keeps for disabled controls. They now take the colours of blockr.ui's other tools, text-muted at rest and text-default on the hover wash, as BristolMyersSquibb/blockr.ui#61 now specifies.
# Conflicts: # NEWS.md
nbenn
marked this pull request as ready for review
September 30, 2026 11:37
nbenn
added a commit
to BristolMyersSquibb/blockr.dock
that referenced
this pull request
Sep 30, 2026
The status spec's literal for the unset and waiting dots is the light value of border-warning, which BristolMyersSquibb/blockr.ui#61 moves from amber-500 to amber-600 (#d97706), the first amber at 3:1 on white. The DAG's canvas draws the literal, and the token test holds it to the token, so this goes up once that PR has merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
border-warning, is amber-600 (#d97706) in light, a new step of the amber ramp. Amber-500 was 2.2:1 on white, under the 3:1 WCAG 1.4.11 asks of an edge or a dot that marks a state, and the unset and waiting status dots and a required empty field's edge are drawn in it. Amber-700, the warning text, would clear 3:1 too, but it is as dark as the danger red (1.04:1 between them), so an unset dot and a failed one would differ by hue alone. Dark is unchanged.bg-surfacein both schemes, the non-text half of what axe checks for text in Chrome. It fails on the old amber.text-mutedwithtext-defaulton hover, in place of a quietertext-disabled, which is 2.5:1 on white and which the token table keeps for disabled controls.block_status_badge()next to their light values, with no--blockr-dock-status-*tokens in blockr.dock. The DAG draws from the same spec.BristolMyersSquibb/blockr.dock#482 implements the dock side. Its tests hold the dot's literals to this package's tokens, so its amber-600 literal goes up once this merges.