Skip to content

Draw status badges from a parked block's held outcome - #491

Merged
nbenn merged 1 commit into
mainfrom
485-held-badge
Sep 30, 2026
Merged

nbenn merged 1 commit into
mainfrom
485-held-badge

Conversation

@nbenn

@nbenn nbenn commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Since Report a parked block's last check and return its result blockr.core#364, core reports a parked block by the outcome of its last check, stale once that is out of date, or unevaluated without one, and never dormant. The dormant case in block_status_badge(), which returned NA so that a persistent renderer such as the blockr.dag node kept the badge it drew last, could no longer be reached. It goes, along with NA in the documented return value.
  • Nothing changes at runtime against current core, and the updated tests pass on the old code too. A new test pins the outcome the issue describes through core's board server: a block checked off screen by an evaluate request reads its held failed once parked and draws the failed badge.
  • An unevaluated block that has raised an error still draws the failed badge, as ready does. Its errors come from the expression server, which runs while the block is parked, so unlike a stale block's they cannot predate a check.
  • The comment on the stale exemption no longer says the change that made a block stale came from upstream, since an own edit now counts too. The unreleased Render the new stale eval status on the block status badge #408 NEWS entry says "parked" where it said "dormant", as core did for its own unreleased entries.

Fixes #485

Core no longer reports `dormant` for a block out of the eval set, so the
case that mapped it to `NA`, telling a persistent renderer to keep its
last badge, could not be reached. Drop it and `NA` from the documented
return value.
@codecov

codecov Bot commented Sep 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
R/block-meta.R 96.00% <ø> (ø)
R/plugin-block.R 99.58% <ø> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nbenn
nbenn marked this pull request as ready for review September 30, 2026 11:31
@nbenn
nbenn added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit 7ef3fec Sep 30, 2026
10 checks passed
@nbenn
nbenn deleted the 485-held-badge branch September 30, 2026 11:52
nbenn added a commit that referenced this pull request Sep 30, 2026
The badge docs keep this branch's wording without the `NA` return, and
the style test keeps the token assertions with #491's `unevaluated` loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Draw status badges from a parked block's held outcome instead of keeping the last one

1 participant