Drop the restore-geometry probe now that the grid is seeded upstream - #481
Merged
Merged
Conversation
The instrumentation added in #474 answered the question it was built for: cynkra/dockViewR#116 traced the ground-down rail to `fromJSON` laying the shell out from a grid the ResizeObserver had not yet seeded, and fixed it there. Nothing reads the probe now, so it comes out whole. The viewport probe is a separate, pre-existing thing feeding the narrow-viewport decision, and stays. One assertion moves with the removal: `board_ui()` counted the probe's slot even when empty, so the tag-list length drops from 15 to 14.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fromJSONlaying the shell out from a grid the ResizeObserver had not yet seeded, and fixed it there. Nothing reads the probe now, so it comes out whole.inst/assets/js/restore-probe.js, the five helpers inR/utils-dock.Rwith their call inrestore_layout(), the conditional dependency inboard_ui(), the observer inmanage_dock(), and the four tests that covered them.test-board-ui.Rdrops from 15 to 14, sinceboard_ui()counted the probe's slot even when it was empty.Fixes #476