Conversation
A check records why a block cannot run whatever asked for it, so an evaluate request or a downstream read raised a lasting toast for a block nobody is looking at. The board exposes the front-end's eager set, TRUE on an ungated board, for the plugin to test such a note against.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Collaborator
Author
|
Closing without merging. Which blocks are on screen is for the front-end to know, so a filter on toasts belongs in the front-end's own notification plugin rather than in a board field that reads |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
status-phase note, whatever asked for the check: anevaluaterequest, a downstream read of the block as input, or "Evaluate blocks" in the code modal. Thenotify_user()plugin toasted every such warning with no duration, so a block nobody was looking at raised a toast that stayed until the block was fixed.status-phase note only for a block the front-end holds eager, the test Render a block when the front-end claims it, not whenvisiblereports it painted #366 moves rendering onto, or for any block on a board no front-end gates. The note is still recorded by every check, for the status badge and the assistant, and conditions from other phases, such as a failed block's error, toast as before.boardbut not which owner is the front-end, so the board now carries the front-end's eager set as afront_end_eagerreactive,TRUEon an ungated board. A block's notification observer reads it only while the block carries a status note, so a change to the eager sets re-runs only those observers.Fixes #370