Move scopes inside #3454
Merged
Move scopes inside #3454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As scopes are now done in the Handler Factories Command Processor Providers are no longer needed
|
@iancooper let me know if you're happy with this direction |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
src/Paramore.Brighter.ServiceActivator/ControlBus/ControlBusReceiverBuilder.cs
Show resolved
Hide resolved
When I publish, particularly in parallel, I would expect state to be fresh. I think the problem with reusing scope, is that's not true. I think we need to ask for a fresh scope for each publish chain. I like where we are, so hopefully we can do that through the lifetime somehow. |
|
The only other alternative is to make them transient within the scope i.e. the publish has the scope, the publish chains are transient within that scope. |
preardon
requested review from
iancooper,
holytshirt and
DevJonny
as code owners
iancooper
approved these changes
Jan 5, 2025
src/Paramore.Brighter.Extensions.DependencyInjection/ServiceProviderHandlerFactory.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the minute the Factory Scope (Dependency injection) is around the command processor, this means that when Publish is called multiple Handlers could share the same scope which would be unexpected by the users.
#3356