[Feature] Generate metrics from traces #3453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
src/Paramore.Brighter/Observability/BrighterMetricsFromTracesProcessor.cs
Show resolved
Hide resolved
jtsalva
changed the title
jtsalva
requested review from
iancooper,
holytshirt,
DevJonny and
preardon
as code owners
iancooper
approved these changes
Jan 3, 2025
| @@ -0,0 +1,85 @@ | |||
| #region Licence | |||
|
|
|||
There was a problem hiding this comment.
If it is a new file, you can add your own name for the copyright in the header. We just need you to sign the CLA so that we have good title to your work.
There was a problem hiding this comment.
How do I sign the CLA, is it a file in git somewhere?
There was a problem hiding this comment.
Ihttps://cla-assistant.io/BrighterCommand/Brighter?pullRequest=3453
Should work
| @@ -115,10 +115,12 @@ public void AddExceptionToSpan(Activity? span, IEnumerable<Exception> exceptions | |||
|
|
|||
| var tags = new ActivityTagsCollection | |||
| { | |||
| { BrighterSemanticConventions.InstrumentationDomain, BrighterSemanticConventions.MessagingInstrumentationDomain }, | |||
| { BrighterSemanticConventions.MessagingOperationType, operation.ToSpanName() }, | |||
| { BrighterSemanticConventions.Operation, operation.ToSpanName() }, | |||
| { BrighterSemanticConventions.RequestId, request.Id }, | |||
|
Thanks for the review @iancooper. I'm happy for it to be merged whenever. |
|
@jtsalva Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to generate metrics from traces as described in #3389 following OpenTelemetry Semantic Conventions 1.29.0 for messaging and database operations.