fix: update method signatures, and minor fixes #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iancooper
requested review from
holytshirt,
DevJonny and
preardon
as code owners
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Comment on lines
+198
to
+207
| private void ExecuteOnCallersContext(ContextCallback contextCallback, object? state, ExecutionContext ctxt) | ||
| { | ||
| Debug.WriteLine(string.Empty); | ||
| Debug.IndentLevel = 1; | ||
| Debug.Fail("BrighterSynchronizationContext: ExecuteOnCallersContext. We should never get here"); | ||
| Debug.WriteLine($"BrighterSynchronizationContext: Post Failed to queue {contextCallback.Method.Name} on thread {Thread.CurrentThread.ManagedThreadId}"); | ||
| Debug.WriteLine($"BrighterSynchronizationContext: Parent Task {ParentTaskId}"); | ||
| Debug.IndentLevel = 0; | ||
| SynchronizationHelper.ExecuteOnContext(ctxt, contextCallback, state); | ||
| } |
There was a problem hiding this comment.
❌ New issue: Code Duplication
The module contains 2 functions with similar structure: ExecuteImmediately,ExecuteOnCallersContext
Comment on lines
-309
to
-315
| try | ||
| { | ||
| var taskTwo = context.Factory.StartNew( | ||
| () => { value = 2; }, | ||
| context.Factory.CancellationToken, | ||
| context.Factory.CreationOptions | TaskCreationOptions.DenyChildAttach, | ||
| context.TaskScheduler); |
There was a problem hiding this comment.
❌ Getting worse: Code Duplication
introduced similar code in: Task_AfterExecute_NeverRuns,Task_AfterExecute_Runs_On_ThreadPool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fixes