Correctly filter out new indexes #3705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dified within 2 days were reversed, resulting in ONLY reporting on very recent indexes.
BrentOzar
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few checks in sp_BlitzIndex were written to filter out tables created in the last 7 days or modified in the last 2 days, but the less-than/greater-than check was reversed. This fixes them.
check_id 21: More Than 5 Percent NC Indexes Are Unused
check_id 29: NC indexes with 0 reads and < 10,000 writes
The relevant lines also had tabs where surrounding lines used spaces, so I fixed that too.
I verified the direction of all other newer/older checks in sp_BlitzIndex and they seem to be correct. I searched the rest of the codebase for similar filters and found none.