Rebase of csharp-record against upstream develop#1
Draft
thedewi wants to merge 135 commits into
Draft
Conversation
* ready * cleaned up and works with released FW * removed cmake verbose message * cp * added Multidevice tests * updated NuGet package name * Fix Linux build break * address feedback and fixed build issue * Fixed build break * Fixed Master/Subordinate detection logic
* Fix link OpenCV * Update OpenCV for CI
* RUNPATH only should be set during build Currently, we set RUNPATH in all our shared objects and executables at both build time and runtime. Build time is needed because we move the binaries around to other machines. However, the install time is not needed. This is step 1 of 2 in order to move the depthengine into a private folder instead of in the /lib folder * Updated comment to explain why its only set during build
Update ARM-support.md
Co-Authored-By: wes-b <wesbarc@microsoft.com>
Co-Authored-By: wes-b <wesbarc@microsoft.com>
Co-Authored-By: wes-b <wesbarc@microsoft.com>
Co-Authored-By: wes-b <wesbarc@microsoft.com>
Co-Authored-By: wes-b <wesbarc@microsoft.com>
Co-Authored-By: Erica Towle <48578768+ETowleMS@users.noreply.github.com>
Co-Authored-By: Erica Towle <48578768+ETowleMS@users.noreply.github.com>
Co-Authored-By: Erica Towle <48578768+ETowleMS@users.noreply.github.com>
Co-Authored-By: Erica Towle <48578768+ETowleMS@users.noreply.github.com>
Co-Authored-By: wes-b <wesbarc@microsoft.com>
Co-Authored-By: wes-b <wesbarc@microsoft.com>
It needs to handle exceptions and retry
* Update Document OpenCV Version Azure Kinect Sensor SDK v1.4.0 and later has been tested with OpenCV 4.1.1. * Remove unnecessary settings from CMakeLists It is not necessary because settings of include directory for OpenCV is done with OpenCV_LIBS. It is redundant.
* Dropping failed conversions from MJPEG
…on.cs Co-Authored-By: Derek M. <MsDerekMa@users.noreply.github.com>
This reverts commit 6b58afb. # Conflicts: # include/k4arecord/record.h # src/csharp/Record/Exceptions/AzureKinectCreateRecordingException.cs # src/csharp/Record/RecordLogger.cs # src/csharp/SDK/Logger.cs # src/csharp/SDK/Native/LoggingTracer.cs # src/csharp/Tests/Record.UnitTests/LoopbackTests.cs # src/record/sdk/record.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's awkward to PR these, but in case it's useful to you, here is a rebase of
csharp-recordoff current upstreamdevelop.The conflicts seemed minor, and I have successfully tested recording functionality.