refactor: extract _registerMember() and _isPreviousRoundTimedOut() helpers#150
Open
Tranquil-Flow wants to merge 1 commit into
Open
refactor: extract _registerMember() and _isPreviousRoundTimedOut() helpers#150Tranquil-Flow wants to merge 1 commit into
Tranquil-Flow wants to merge 1 commit into
Conversation
#113) Extract duplicated logic into internal helper functions to reduce code duplication and improve maintainability: - _registerMember(): deduplicates member registration in create() and redeemInvite() - _isPreviousRoundTimedOut(): deduplicates missed-deposit checks across _deposit(), circleState(), and _isDecommissionable() Adds NatSpec @dev documentation to both helpers. All 141 tests pass unchanged. - Closes: #113
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #113
Extracts two internal helpers to eliminate duplicated logic:
_registerMember(id, member): consolidates the 5-line member registration pattern used in bothcreate()andredeemInvite()_isPreviousRoundTimedOut(id, circle, currentRound): consolidates the missed-deposit check duplicated across_deposit(),circleState(), and_isDecommissionable()Behavior-preserving refactor. No functional changes.
Changes
_registerMember(): extracted fromcreate()andredeemInvite()_isPreviousRoundTimedOut(): extracted from_deposit(),circleState(),_isDecommissionable()_isDecommissionable(): cleaned up expired-circle edge case handling witheffectiveRoundTest plan
forge testpasses (140 tests)