perf: decommission() O(N²) → O(N) by batching member transfers#147
Open
Tranquil-Flow wants to merge 1 commit into
Open
perf: decommission() O(N²) → O(N) by batching member transfers#147Tranquil-Flow wants to merge 1 commit into
Tranquil-Flow wants to merge 1 commit into
Conversation
Refactor decommission() to aggregate refunds per depositor across all unclaimed rounds before executing transfers. Reduces external safeTransfer calls from O(N²) worst case to at most N (one per member). - Consolidate per-member refunds in memory before executing transfers - Remove unnecessary SSTORE zeroing of roundDeposits - Closes: #120
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #120
decommission()previously made onesafeTransfercall per member per unclaimed round — O(N²) external calls in the worst case. Each call costs ~20k gas overhead.This refactors the refund loop to aggregate all owed amounts per depositor into a memory array, then executes a single transfer per member.
Changes
uint256[] memoryarray indexed by member positionsafeTransferper member after aggregationroundDeposits(circle is deactivated, data is dead)Test plan
forge testpasses (140 tests)