fix: add explicit InsufficientPoolLiquidity checks#81
Open
Tranquil-Flow wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds explicit
InsufficientPoolLiquidityerror checks before pool balance decrements, replacing opaquePanic(0x11)arithmetic underflow reverts with a named, catchable error.Changes
InsufficientPoolLiquidity()_withdraw()small path — beforesafetyNetBalance[_id] -= _withdrawAmount_deduct()large path — beforesafetyNetBalance[_safetyNetId] -= _amountWhy
Normal accounting keeps
memberWithdrawableBalance ≤ safetyNetBalance, so these guards shouldn't fire in practice. But if a bug, admin action, or future upgrade ever de-synchronises the two balances, the contract would previously emit an opaquePanic(0x11). The explicit check makes on-chain debugging and client-side error handling straightforward.Testing
3 new tests including 2 using
vm.storeto simulate de-synchronised accounting. All 100 tests pass.Closes #30