ci(deploy): scope testnet deploy to a GitHub Environment#47
Draft
rubydusa wants to merge 1 commit into
Draft
Conversation
Add an `environment` input to `_deploy-testnet.yml` and a
`deploy-environment` input to `_foundry-cicd.yml`, both defaulting
to `testnet`. The deploy job declares `environment: ${{ inputs... }}`
so consumer repos can require reviewers and scope `PRIVATE_KEY` to
the Environment.
Empty string opts out for sandbox use.
Closes #41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41.
Summary
environmentinput to_deploy-testnet.yml(defaulttestnet).deploy-environmentinput to_foundry-cicd.yml(defaulttestnet), forwarded to the orchestrator'sdeploy-testnetjob.environment: ${{ inputs.* }}so consumer repos can require reviewers and scopePRIVATE_KEYto the Environment.Why
Closes the gap between
docs/specs/...(which calls for "deploy on approved PR to main") and the implementation. Today any PR withdeploy-on-pr: truedeploys without approval. With this change, the consumer repo's Environment protection rules (required reviewers, branch policy) are the gate.Behavior change
testnetEnvironment in their repo, or runs will sit waiting (or fail with "no environment found", depending on the GH config). This is intended — it's the point of the gate.environment: ''/deploy-environment: ''.Test plan
testnetEnvironment configured.🤖 Generated with Claude Code