Rubydusa/sticky pr comment with addresses#37
Merged
Conversation
Contributor
Author
|
proof of this working: |
…mment-with-addresses # Conflicts: # .github/workflows/_deploy-testnet.yml # .github/workflows/_foundry-cicd.yml
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new helper script and CI wiring to publish a sticky PR comment containing deployed contract addresses (with explorer links) for testnet deployments, complementing the existing deployment summary/coverage reporting tooling.
Changes:
- Add
scripts/deploy/deployment-comment.shto renderdeployment-summary.txtinto a markdown file suitable for sticky PR comments. - Add unit tests for the new script and run them in the scripts test workflow.
- Update reusable deployment workflows to write/post the sticky deployment comment and grant required PR write permissions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/test-deployment-comment.sh |
Adds bash tests covering rendering, title behavior, output path, and missing env handling. |
scripts/deploy/deployment-comment.sh |
Implements generation of deployment-comment.md from deployment-summary.txt with explorer links. |
.github/workflows/test.yml |
Runs the new deployment-comment test in CI. |
.github/workflows/_foundry-cicd.yml |
Posts the deployment address comment during PR-triggered testnet deploys; adds PR write permissions. |
.github/workflows/_deploy-testnet.yml |
Posts the deployment address comment during PR-triggered reusable testnet deploys; adds PR write permissions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sticky pr comment with addresses of contracts
Q: Should the coverage comment and addresses comment be one?Decided against it - user could possibly not want testnet releases and the separation play nicely here