fix: address PR #32 review comments#33
Merged
RonTuretzky merged 2 commits intoApr 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses review comments from @rubydusa on PR #32.
run-upgrade-safetyinput — upgrade safety always runs; removes the issue where disabling it implicitly blocked testnet deploymentcache: ${{ inputs.package-manager }}instead of ternary expression;setup-nodeignores invalid cache valuesprepare-env.shfails on malformed lines — lines without=or with invalid key names now error instead of being silently skippedvalidate-config.sh— checks that no.contractentries were removed compared to the base branch (subset check by contract name, not just count)validate.sh— empty contracts array is a simple skip; complex base-branch comparison logic moved to the dedicated config validation script; removedALLOW_FALLBACKTest plan
shellcheckpasses on all scriptsbash tests/test-*.sh)run-upgrade-safetytoggle)validate-config.shcatches removed contractsprepare-env.shfails on malformedDEPLOY_ENV_VARS🤖 Generated with Claude Code