Skip to content

test: consolidate release-on-merge into foundry-cicd wrapper#11

Merged
rubydusa merged 1 commit into
mainfrom
Rubydusa/test-all-in-one-release
Apr 30, 2026
Merged

test: consolidate release-on-merge into foundry-cicd wrapper#11
rubydusa merged 1 commit into
mainfrom
Rubydusa/test-all-in-one-release

Conversation

@rubydusa
Copy link
Copy Markdown
Collaborator

Summary

Tests the new single-wrapper UX for testnet releases shipped in etherform PR #38.

  • Drops the standalone release-testnet.yml wrapper.
  • foundry-cicd.yml now handles both CI (on push/PR open/sync) and testnet release (on PR merge) via the new release-on-merge: true input on _foundry-cicd.yml.
  • Adds closed to the wrapper's pull_request types and bumps permissions.contents to write so the inlined release job can create the GitHub Release.
  • Touches src/SimpleNFT.sol so dorny/paths-filter does not skip CI on this PR.

Pinned to etherform-ref: Rubydusa/address-release-on-merge while the etherform-side PR is in flight.

Test plan

  • CI/CD workflow runs on this PR (build, tests, coverage, upgrade-safety, deploy-testnet) — the release-testnet job should be skipped while the PR is open.
  • On merge, the pull_request: closed event fires the workflow with should-run=false for CI/upgrade-safety/deploy, and only the release-testnet job runs.
  • A GitHub Release tagged testnet-pr-<this-PR-number> is created with the deployed contract addresses and Blockscout links.
  • Concurrent push-to-main from the merge does not cancel the release run (different concurrency group via event_name).

🤖 Generated with Claude Code

Drops the separate release-testnet.yml wrapper and switches to a single
foundry-cicd.yml that handles CI on PR/push and a testnet release on
merge via the new release-on-merge input on _foundry-cicd.yml.

Trigger: small change to SimpleNFT.sol so paths-filter does not skip CI.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

Coverage Report

Metric Coverage
Lines 1.96% (2/102)
Statements 0.88% (1/114)
Branches 0.00% (0/19)
Functions 5.00% (1/20)
Coverage by file
File Lines Statements Branches Functions
src/Marketplace.sol 0.00% (0/32) 0.00% (0/38) 0.00% (0/8) 0.00% (0/5)
src/MarketplaceV2.sol 4.55% (2/44) 1.89% (1/53) 0.00% (0/10) 14.29% (1/7)
src/SimpleNFT.sol 0.00% (0/10) 0.00% (0/8) 100.00% (0/0) 0.00% (0/3)
src/SimpleNFTV2.sol 0.00% (0/16) 0.00% (0/15) 0.00% (0/1) 0.00% (0/5)

@rubydusa rubydusa merged commit 0ce4831 into main Apr 30, 2026
8 checks passed
@rubydusa rubydusa deleted the Rubydusa/test-all-in-one-release branch April 30, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant