fix: add quadratic scaling penalty to TimeWeightedVotingPower (#91)#107
Open
Tranquil-Flow wants to merge 4 commits into
Open
fix: add quadratic scaling penalty to TimeWeightedVotingPower (#91)#107Tranquil-Flow wants to merge 4 commits into
Tranquil-Flow wants to merge 4 commits into
Conversation
Fix time-weighted voting power scaling to use the correct period denominator, preventing inflated or deflated power values when the scaling window does not align with cycle boundaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TimeWeightedVotingPowerscalingPeriod > 0, intervals shorter thanscalingPeriodreceive quadratic penalty:contribution = value * duration^2 / scalingPeriodMAX_SCALING_PERIODconstant (~365 days in blocks) with upper-bound validationvotingToken/cycleModuletoVOTING_TOKEN/CYCLE_MODULE(immutable naming convention)setScalingPeriod()with owner-only access and event emissionCloses #91
Test plan
testScalingPeriodDisabledWhenZero— no penalty when scalingPeriod=0testQuadraticPenaltyApplied— 40-block interval with scalingPeriod=100 reduces 100 ETH to 40 ETHtestNoPenaltyWhenIntervalExceedsScalingPeriod— no reduction at boundarytestScalingPeriodOnlyAffectsShortIntervals— no reduction above boundarytestSetScalingPeriodByOwner/testSetScalingPeriodEmitsEvent— admin functionstestSetScalingPeriodRevertsNonOwner/testSetScalingPeriodRevertsExceedsMax— access controltestFlashLoanMitigatedByScaling— 1000 ETH for 1 block → 10 ETH (100x reduction)