forked from streamlit/streamlit
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Migrate Frontend stack to Vite/Vitest (streamlit#9165)
## Describe your changes These changes does the following: - Remove Create-React-App - Migrates from Webpack to Vite - Migrates Jest to Vitest It's hard to separate these out because CRA provided a lot of the infrastructure, so to separation it requires reconfiguration. Generally, the changes to make the tests pass involve the following: - Migrating some jest specific code to Vitest (I alias jest as vi in order to make the rest of the code the same and will migrate away from that in a future PR. - Some updated matching including: - colors are represented as rgba in the end. - Screenshots (which kinda doesn't make sense, but Playwright selects the text on double click with Vite) - We desire images to be relative and it's difficult to do in vite (open to ideas) the best I got is moving the images for running man to the public folder to be included and then reference the relative name for the path. ### Stats - Build time improved CPU performance by 27-41% - 0 to Dev Server is ~50% less time ## Testing Plan - Tests are all updated and should pass --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
- Loading branch information
Showing
84 changed files
with
11,595 additions
and
9,730 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+35 Bytes
(100%)
...ame_interactions_test/st_data_editor-number_col_editor[dark_theme-chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-96 Bytes
(93%)
...rame_interactions_test/st_data_editor-number_col_editor[dark_theme-firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+27 Bytes
(100%)
...frame_interactions_test/st_data_editor-number_col_editor[dark_theme-webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+55 Bytes
(110%)
...me_interactions_test/st_data_editor-number_col_editor[light_theme-chromium].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-110 Bytes
(92%)
...ame_interactions_test/st_data_editor-number_col_editor[light_theme-firefox].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+67 Bytes
(110%)
...rame_interactions_test/st_data_editor-number_col_editor[light_theme-webkit].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.