Fix support for cast in $expand - expand some property on derived type only #44
Conversation
| @@ -175,6 +175,13 @@ private static Expression BuildSelectorExpression(Expression sourceExpression, L | |||
| } | |||
| else | |||
| { | |||
| if (parent.Type != parts[i].ParentType) | |||
There was a problem hiding this comment.
I think we want to throw an exception here if parent.Type is not assignable form parts[i].ParentType ?
There was a problem hiding this comment.
I assumed that OData would take care of this check beforehand, and there was no tests for the validity of getting the parts[i].MemberName member out of the parent.Type type (which caused my issue btw).
Both of these errors return perfectly readable and troubleshootable error messages so.. What do you think ?
There was a problem hiding this comment.
Just FYI this library does not assume an OData caller. Not a huge deal. A unique message makes it easier to pinpoint even throw new InvalidOperationException("{EFF2398E-8BA7-4A52-A098-AEDF6280F790}"); is helpful.
I will implement the tests (both repos) |
No description provided.