Support Smart-Home-Interface Part 5: Main interface #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Field is set to true if value-setter is called. Field is set to false if raw-setter is called. Field can be reset by the interface.
…alculate them on every read
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Guzz-T
force-pushed
the
issue/190/interface
branch
from
b642f7c to
6b1d57b
Compare
Collaborator
|
@Guzz-T Since you've pushed some new commits: Is this still work-in-progress, or ready to be reviewed? |
Contributor
Author
|
It should be finished. There might be a few minor changes later, but those could also be included in the next pull request. |
…d together by the getters of the list and the definitions
Contributor
Author
|
Since there are still no review comments, I’ve (once again) pushed a small change to reduce the overall effort required for the whole review 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fifth pull request to gradually integrate the smart home interface. This pull request includes:
Contiguous blocks: Helper classes to group read/write operations
Interface: Main interface for the user
Pytest units for new methods and classes
Part 5 for #190
Extensions not yet included: