Skip to content

Conversation

gerw
Copy link
Collaborator

@gerw gerw commented Feb 23, 2024

This adds the suggestion of #168.

The test cases detect if

  • a new parameter/calculation/visibility is added, and it also has to be added to the test suite (to make sure that the name is preserved in the future)
  • a name has changed.

For obsoleted names, an error is thrown. I am not sure about the test case which checks for the error, because this means that the ID of the obsolete item has to be added to compatibilities.py and to the test suite.

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __init__.py18113128%39–51, 73–77, 80, 84–89, 93–97, 108–111, 119–121, 128–130, 137–139, 146–148, 157, 165–167, 170–173, 176–179, 182–198, 201–215, 218–234, 237–251, 255–257, 261–262, 266–267, 278–280, 283, 286, 289, 292, 295–298, 301–304
   __main__.py21210%3–49
   datatypes.py275199%82
   discover.py403415%21–69
luxtronik/scripts
   dump_changes.py44440%5–85
   dump_luxtronik.py27270%5–52
TOTAL68425862% 

Tests Skipped Failures Errors Time
123 0 💤 0 ❌ 0 🔥 0.986s ⏱️

@gerw gerw added this to the New pypi release 0.3.15 milestone Feb 23, 2024
Guzz-T added a commit to Guzz-T/python-luxtronik that referenced this pull request Nov 2, 2024
Guzz-T added a commit to Guzz-T/python-luxtronik that referenced this pull request Nov 2, 2024
Guzz-T added a commit to Guzz-T/python-luxtronik that referenced this pull request Nov 2, 2024
Guzz-T added a commit to Guzz-T/python-luxtronik that referenced this pull request Nov 2, 2024

if target_index is None:
# Resolve compatibility mapping
target = LUXTRONIK_COMPATIBILITIES.get(target, target)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we log / raise a warning in case you're using an "old" name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants