Skip to content

No Case: Remove the casting to Float32 in SampleBatch. #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: releases/1.3.0
Choose a base branch
from
Open

No Case: Remove the casting to Float32 in SampleBatch. #78

wants to merge 3 commits into from

Conversation

RuofanKong
Copy link
Collaborator

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kiko-Aumond Kiko-Aumond Awaiting requested review from Kiko-Aumond

1 more reviewer

@Edilmo Edilmo Edilmo approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RuofanKong @Edilmo