fix: Don't show swaps as 'refundable' when there was no lockup tx #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kiocosta is attempting to deploy a commit to the boltz Team on Vercel. A member of the Team first needs to authorize it. |
kiocosta
force-pushed
the
show-lockup-txs-only
branch
3 times, most recently
from
ff38c44 to
8618332
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kilrau
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Sorry for the late review, many of us are travelling. tACK from my side (no code review)
I tested the following 4 scenarios:
- paying correctly and letting a swap fail (e.g.
invoice.failedToPay): displayed ✅ - paying an incorrect amount: displayed ✅
- letting a swap expire without paying: not displayed ✅
- With "paying them after they've expired (these were displayed);" you made it sound like you are already did Refund: use 3rd party blockexplorer endpoints to double check if a lockup address has funds #809 but that's not the case. All good, let's handle Refund: use 3rd party blockexplorer endpoints to double check if a lockup address has funds #809 separately. ✅
michael1011
requested changes
Feb 4, 2025
src/pages/Refund.tsx
Outdated
Comment on lines
35
to
37
| [swapStatusFailed.TransactionLockupFailed].includes( | ||
| swap.status, | ||
| ), |
There was a problem hiding this comment.
Suggested change
| [swapStatusFailed.TransactionLockupFailed].includes( | |
| swap.status, | |
| ), | |
| swapStatusFailed.TransactionLockupFailed === swap.status, |
kiocosta
force-pushed
the
show-lockup-txs-only
branch
from
8618332 to
6d0655a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #806
I have tested this by creating a few swaps and: