Create pullzone on FSD enable for Total CDN if it's missing #1237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## total-cdn-staging #1237 +/- ##
=======================================================
- Coverage 2.28% 2.28% -0.01%
- Complexity 20220 20232 +12
=======================================================
Files 669 669
Lines 102092 102129 +37
=======================================================
Hits 2335 2335
- Misses 99757 99794 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This pull request adds auto-configuration capability for Total CDN Full Site Delivery (FSD) during the settings save process. When enabling Total CDN FSD without an existing pull zone, the system will attempt to automatically provision one.
- Adds a new helper method to determine when auto-configuration should be triggered
- Modifies the auto-configuration run method to optionally skip enabling the CDN after provisioning
- Implements error handling and rollback logic when auto-configuration fails
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Generic_Plugin_Admin.php | Adds auto-configuration check during save, rollback logic on failure, and error message for auto-configuration failures |
| Cdn_TotalCdn_Auto_Configure.php | Extends the run method to support configuration without enabling the CDN |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check and fix if the pullzone doesn't exist on FSD enable for Total CDN
To test, deauthorize and delete your pull zone and delete from the CDNAPI (if needed). Then enable FSD and confirm that a new pull zone was created and configured correctly