Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates documentation and CI while expanding test coverage around the new coupled-glycome simulation utilities.
Changes:
- Add HSIC-based tests for coupled-glycome injection behavior and coupling direction normalization.
- Improve README installation/usage details and add a citation block.
- Update the benchmarking notebook imports and add a GitHub Actions workflow to run pytest.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
tests/test_core_functions.py |
Adds coupling-related tests (HSIC permutation test + unit-norm validation). |
README.md |
Updates install/usage text and adds citation details. |
benchmarking_batch_effect_removal.ipynb |
Switches to use_cases.batch_correction.* imports and creates results/figures/. |
.github/workflows/tests.yml |
Introduces a CI job to run the test suite on PRs/pushes to main. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and updates across the project, focusing on documentation clarity, testing automation, and enhanced test coverage. The most notable changes are the addition of a GitHub Actions workflow for automated testing, significant enhancements and corrections to the
README.mdfor better usability and accuracy, and new tests for glycome coupling logic.Documentation improvements:
README.mdto clarify Python version requirements, add virtual environment setup instructions, expand usage and simulation mode documentation, correct parameter descriptions, and include a citation section for GlycoForge. [1] [2] [3] [4] [5] [6] [7]Continuous integration:
.github/workflows/tests.ymlworkflow to automatically install dependencies and run tests on pushes and pull requests to themainbranch, ensuring code reliability.Testing and benchmarking:
tests/test_core_functions.pyfor glycome coupling, including statistical independence and coupling detectability checks, as well as norm validation for coupling directions.benchmarking_batch_effect_removal.ipynbto use explicit imports from theuse_cases.batch_correctionsubmodules, create a results directory for figures, and update kernel metadata for consistency. [1] [2] [3] [4]