Add typed KIS parameter helpers#19
Merged
Merged
Conversation
Co-authored-by: multica-agent <github@multica.ai>
There was a problem hiding this comment.
The typed KIS parameter helpers implementation is well-designed and maintains backward compatibility. The PR successfully adds type safety for account products, market divisions, and cash order divisions while preserving existing string-based APIs. All 49 tests pass, demonstrating comprehensive coverage of the new functionality. The changes follow Rust best practices with proper trait implementations (Display, FromStr, Serialize) and validation logic.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
Co-authored-by: multica-agent <github@multica.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stringrequest fields, string constants, and&stroperation-id methods available for downstream compatibility.main, resolve the README conflict with the BOG-258 user-facing mock cleanup intact, bumpkis-sdkto0.2.1, and update README plus English/Korean usage docs for the typed API path.Verification
cargo fmt --checkpassedcargo test --lockedpassed (mock_server_contract4 passed,sdk_core45 passed, doc-tests 0 passed)cargo metadata --locked --format-version 1 --no-depspassed and confirmedkis-sdk 0.2.1python3 scripts/verify-crates-publishable.pypassed (Publishable crates.io package(s): - kis-sdk 0.2.1)git diff --check --cachedpassedcargo doc --locked --no-depspassed<<<<<<<,=======,>>>>>>>not found)cargo test --locked typed_ --test sdk_corepassed (2 passed), and static API compatibility confirmed existingAccount::new,Stringrequest fields,&stroperation-id methods, and string constants were not removedCoordination