Skip to content

throttle OnUpdate #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ScottIngram wants to merge 1 commit into
base: master
Choose a base branch
from
Open

throttle OnUpdate #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion FloFlyout.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,19 @@ local function Opener_UpdateFlyout(self)
end
end

-- throttle OnUpdate because it fires as often as FPS and is very resource intensive
local ON_UPDATE_TIMER_FREQUENCY = 1.5
local onUpdateTimer = 0
local function Opener_UpdateFlyout_OnUpdate(self, elapsed)
onUpdateTimer = onUpdateTimer + elapsed
if onUpdateTimer < ON_UPDATE_TIMER_FREQUENCY then
return
end
onUpdateTimer = 0
print("=1======== Opener_UpdateFlyout_OnUpdate()")
Opener_UpdateFlyout(self)
end

local function Opener_PreClick(self, button, down)
self:SetChecked(not self:GetChecked())
local direction = self:GetAttribute("flyoutDirection");
Expand Down Expand Up @@ -616,7 +629,8 @@ function FloFlyout:CreateOpener(name, idFlyout, actionId, direction, actionButto
opener:SetAttribute("spellnamelist", strjoin(",", unpack(flyoutConf.spellNames)))
opener:SetAttribute("typelist", strjoin(",", unpack(flyoutConf.actionTypes)))

opener:SetScript("OnUpdate", Opener_UpdateFlyout)
-- TODO: find a way to eliminate the need for OnUpdate
opener:SetScript("OnUpdate", Opener_UpdateFlyout_OnUpdate)
opener:SetScript("OnEnter", Opener_UpdateFlyout)
opener:SetScript("OnLeave", Opener_UpdateFlyout)

Expand Down