test: cover pounds/catty unit conversion in Mi Scale parsers - #352
Open
bluetoothbot wants to merge 1 commit into
Open
bluetoothbot wants to merge 1 commit into
bluetoothbot wants to merge 1 commit into
Conversation
The _parse_scale_v1 and _parse_scale_v2 pound and catty conversion branches had no coverage — only the kilograms path was exercised. A regression in either conversion factor would silently give wrong weights to users in lb/catty locales. Adds four tests (V1/V2 x pounds/catty) with the parser as the oracle.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
==========================================
+ Coverage 59.41% 59.98% +0.56%
==========================================
Files 7 7
Lines 1412 1412
Branches 278 278
==========================================
+ Hits 839 847 +8
+ Misses 444 438 -6
+ Partials 129 127 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Ernst79
marked this pull request as ready for review
August 10, 2026 18:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Add test coverage for the pounds and catty weight-unit conversion branches in the legacy Mi Scale parsers.
Why:
_parse_scale_v1(XMTZC01HM/04HM) and_parse_scale_v2(XMTZC02HM/05HM/NUN4049CN) convert the raw mass field to kilograms based on a unit flag in the control byte(s). Only the kilograms path had tests — thelbs → kg(×0.0045359237) andcatty → kg(×0.005) branches were entirely uncovered, so a regression in either factor would silently ship wrong weights to users in lb/catty locales.How: Four tests (V1/V2 × pounds/catty), each a synthesized advert with the appropriate unit bit set. Pounds values are asserted as the exact arithmetic expression (
field * 0.0045359237) for bit-exact float equality; catty fields were chosen to land on clean values (87.0 kg). Parser used as the oracle.Testing:
poetry run pytest tests/→ 136 passed (was 132). black/isort/flake8 clean.Quality Report
Changes: 1 file changed, 310 insertions(+)
Code scan: clean
Tests: failed (FAILED)
Branch hygiene: clean
Generated by Kōan