-
Notifications
You must be signed in to change notification settings - Fork 17
Steel i profile strength class 3 moment #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 840-feature-request-add-first-steel-check-to-blueprints
Are you sure you want to change the base?
Steel i profile strength class 3 moment #845
Conversation
…cording to Eurocode 3
… class and enhance latex output; add unit tests for validation.
…fy parameters and add details for NormalForceCheck class.
…Steel I-Profile strength class 3
…tor heb_profile fixture
…lation; update test fixture documentation.
…eel-i-profiles-class-3
…ileStrengthClass3
…enhance LaTeX formatting and improve test cases for compression checks.
…enhance LaTeX formatting for short and detailed outputs.
…improve LaTeX representation and streamline logic for tension and compression checks.
… None area values and ensure correct tension and compression checks.
…leStrengthClass3 for clarity and update corresponding test cases.
…oordinate-system-for-all-strenthstability-checks' into 830-feature-request-check-for-strength-of-steel-i-profiles-class-3
… for load combinations and add single axis bending moment checks.
…Steel I-Profile strength class 3
… Steel I-Profiles
…and update method names for clarity
… simplified ResultInternalForce1D instantiation
…el I-Profile strength class 3
…validation and check for leading slashes
…eel I-Profile strength class 3
…ompression checks, update latex output validation, and refactor test structure
…rminology, update related tests for consistency, and add validation for invalid axis input.
…k axis summary test in Steel I-Profile strength class 3
…logy for bending moments, and enhance test coverage for various loading scenarios in class 3.
…e parameterized testing for single force permutations, enhancing test coverage and reducing redundancy.
…or clarity in force descriptions
…cks for clarity in Steel I-Profile strength class 3
…e strength class 3
…oordinate-system-for-all-strenthstability-checks' into 830-feature-request-check-for-strength-of-steel-i-profiles-class-3
…to use updated ResultInternalForce1D structure
…documentation; remove unimplemented tests
…eel-check-to-blueprints' into 830-feature-request-check-for-strength-of-steel-i-profiles-class-3
…gth class 3; add tests for validation
|
Thank you so much for contributing to Blueprints! Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds bending moment resistance checks to the steel I-profile class 3 strength verification according to Eurocode 3. The implementation extends the existing normal force checks with single-axis bending moment checks (My and Mz axes), following EC3 chapter 6.2.5.
Key changes:
- Implementation of
SingleAxisBendingMomentcheck class with support for both My and Mz axes - Introduction of SAF (Structural Analysis Format) data structures for representing internal forces
- Reorganization of check module structure with proper separation of steel and concrete checks
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
blueprints/saf/results/result_internal_force_1d.py |
New dataclass implementing SAF standard for 1D internal forces with validation |
blueprints/checks/steel/strength/steel_i_profile_strength_class_3.py |
Main implementation adding SingleAxisBendingMoment check class and integration into overall check method |
blueprints/unit_conversion.py |
Added KNM_TO_NMM conversion constant for moment units |
tests/checks/steel/strength/test_steel_i_profile_strength_class_3.py |
Comprehensive tests for normal force and bending moment checks with multiple force permutations |
tests/saf/forces/test_result_internal_force_1d.py |
Unit tests for SAF internal force dataclass including validation and edge cases |
Various __init__.py files |
Package structure reorganization and documentation updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
blueprints/checks/steel/strength/steel_i_profile_strength_class_3.py
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 840-feature-request-add-first-steel-check-to-blueprints #845 +/- ##
==========================================================================================
Coverage 100.00% 100.00%
==========================================================================================
Files 395 396 +1
Lines 12155 12291 +136
==========================================================================================
+ Hits 12155 12291 +136 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…use \newline instead of \\ for improved readability
…e strength checks
Must be evaluated after #836 is merged
Description
Adds bending moment checks to steel i class 3 strenght checks
Type of change
Checklist: