Skip to content

Conversation

@GerjanDorgelo
Copy link
Contributor

Must be evaluated after #836 is merged

Description

Adds bending moment checks to steel i class 3 strenght checks

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

… class and enhance latex output; add unit tests for validation.
…fy parameters and add details for NormalForceCheck class.
…enhance LaTeX formatting and improve test cases for compression checks.
…enhance LaTeX formatting for short and detailed outputs.
…improve LaTeX representation and streamline logic for tension and compression checks.
… None area values and ensure correct tension and compression checks.
…leStrengthClass3 for clarity and update corresponding test cases.
…oordinate-system-for-all-strenthstability-checks' into 830-feature-request-check-for-strength-of-steel-i-profiles-class-3
… for load combinations and add single axis bending moment checks.
… simplified ResultInternalForce1D instantiation
…ompression checks, update latex output validation, and refactor test structure
…rminology, update related tests for consistency, and add validation for invalid axis input.
…k axis summary test in Steel I-Profile strength class 3
…logy for bending moments, and enhance test coverage for various loading scenarios in class 3.
…e parameterized testing for single force permutations, enhancing test coverage and reducing redundancy.
…cks for clarity in Steel I-Profile strength class 3
…oordinate-system-for-all-strenthstability-checks' into 830-feature-request-check-for-strength-of-steel-i-profiles-class-3
…to use updated ResultInternalForce1D structure
…eel-check-to-blueprints' into 830-feature-request-check-for-strength-of-steel-i-profiles-class-3
@GerjanDorgelo GerjanDorgelo self-assigned this Nov 29, 2025
Copilot AI review requested due to automatic review settings November 29, 2025 07:39
@GerjanDorgelo GerjanDorgelo marked this pull request as draft November 29, 2025 07:39
@github-actions
Copy link

Thank you so much for contributing to Blueprints!
Your contributions help thousands of engineers work more efficiently and accurately.

Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added!

@GerjanDorgelo GerjanDorgelo changed the base branch from main to 840-feature-request-add-first-steel-check-to-blueprints November 29, 2025 07:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds bending moment resistance checks to the steel I-profile class 3 strength verification according to Eurocode 3. The implementation extends the existing normal force checks with single-axis bending moment checks (My and Mz axes), following EC3 chapter 6.2.5.

Key changes:

  • Implementation of SingleAxisBendingMoment check class with support for both My and Mz axes
  • Introduction of SAF (Structural Analysis Format) data structures for representing internal forces
  • Reorganization of check module structure with proper separation of steel and concrete checks

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
blueprints/saf/results/result_internal_force_1d.py New dataclass implementing SAF standard for 1D internal forces with validation
blueprints/checks/steel/strength/steel_i_profile_strength_class_3.py Main implementation adding SingleAxisBendingMoment check class and integration into overall check method
blueprints/unit_conversion.py Added KNM_TO_NMM conversion constant for moment units
tests/checks/steel/strength/test_steel_i_profile_strength_class_3.py Comprehensive tests for normal force and bending moment checks with multiple force permutations
tests/saf/forces/test_result_internal_force_1d.py Unit tests for SAF internal force dataclass including validation and edge cases
Various __init__.py files Package structure reorganization and documentation updates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2b5e218) to head (f640632).

Additional details and impacted files
@@                                    Coverage Diff                                     @@
##           840-feature-request-add-first-steel-check-to-blueprints      #845    +/-   ##
==========================================================================================
  Coverage                                                   100.00%   100.00%            
==========================================================================================
  Files                                                          395       396     +1     
  Lines                                                        12155     12291   +136     
==========================================================================================
+ Hits                                                         12155     12291   +136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants