Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused File / Change Text in core/BaseActivity.java, .github/ISSUE_TEMPLATE/Bug_report.md #6

Merged
merged 3 commits into from
Oct 10, 2019
Merged

Remove unused File / Change Text in core/BaseActivity.java, .github/ISSUE_TEMPLATE/Bug_report.md #6

merged 3 commits into from
Oct 10, 2019

Conversation

Aftermoon-dev
Copy link
Member

@Aftermoon-dev Aftermoon-dev commented Oct 10, 2019 •
edited
Loading

resolved #5

  1. Remove test.txt
    • Project don't have to contain test.txt.
  2. Change Text
    • BaseActivity.java : 2016 skydoves -> 2019 Team Mulro in BlueCat-Community
    • Bug_report.md : Library -> Application

@PaleCosmos
Copy link
Member

저희 기준이 3명 동의였나요??

@Aftermoon-dev
Copy link
Member Author

@PaleCosmos 넵 3명 동의였을거에요!

@PaleCosmos
Copy link
Member

동의하는부분입니다

@jungh0
Copy link
Member

jungh0 commented Oct 10, 2019

동의합니당

@rurimo
Copy link
Member

rurimo commented Oct 10, 2019

merge pass는 우측 상단에 있는 review를 통해서 하실 수 있습니다!

PaleCosmos
PaleCosmos reviewed Oct 10, 2019
View reviewed changes
Copy link
Member

@PaleCosmos PaleCosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최고입니다

@PaleCosmos PaleCosmos self-requested a review October 10, 2019 01:05
@PaleCosmos
Copy link
Member

merge pass는 우측 상단에 있는 review를 통해서 하실 수 있습니다!

그냥 체크만 해놓으면 동의하는건가요??

@rurimo
Copy link
Member

rurimo commented Oct 10, 2019

@Aftermoon-dev
혹시 here에 있는 package="com.skydoves.core" 요거 요타도 com.bluecat.core으로 변경 부탁드립니다. 😂

@rurimo
Copy link
Member

rurimo commented Oct 10, 2019

@PaleCosmos
우측 상단에서 Reviewers에서 리뷰어를 추가하면, 리뷰어들은 우측 상단에 Add Review 라는 버튼이 생깁니다 ㅎㅎ 여기서 새로운 PR에 대한 comment를 해주시면 됩니다.

rurimo
rurimo approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@rurimo rurimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

PaleCosmos
PaleCosmos approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@PaleCosmos PaleCosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

된건가?

@Aftermoon-dev
Copy link
Member Author

@Aftermoon-dev
혹시 here에 있는 package="com.skydoves.core" 요거 요타도 com.bluecat.core으로 변경 부탁드립니다. 😂

@rurimo 넵 알겠습니다!

@rurimo rurimo merged commit c4d8046 into BlueCat-Community:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rurimo rurimo

@PaleCosmos PaleCosmos

@jungh0 jungh0

@devFallingstar devFallingstar

@tlaabs tlaabs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused File / Change Text in core/BaseActivity.java, .github/ISSUE_TEMPLATE/Bug_report.md
4 participants
@Aftermoon-dev @PaleCosmos @jungh0 @rurimo