Fix loading of resources that have encoded chars in id #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinika
force-pushed
the
fix-resource-container-e2e-test
branch
2 times, most recently
from
33572b0 to
d6ed715
Compare
danburonline
approved these changes
Feb 23, 2024
Dinika
force-pushed
the
fix-resource-container-e2e-test
branch
10 times, most recently
from
94a31ce to
62bcffa
Compare
|
@Dinika, do you have any idea why the two E2E test cases are still failing? Manually going through the flow appears to be successful... |
Dinika
force-pushed
the
fix-resource-container-e2e-test
branch
3 times, most recently
from
d78f69c to
51d4656
Compare
Signed-off-by: Dinika Saxena <[email protected]>
Dinika
force-pushed
the
fix-resource-container-e2e-test
branch
from
51d4656 to
d7ba71d
Compare
|
@Dinika As discussed with Bilal, we will comment out the only failing E2E test to proceed with a passing CI. Let me know if that's okay with you as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of this PR, rebased on
migration-merge- #1512Description
How has this been tested?
Types of changes
Checklist: