Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve slack notification for public studios cron job #1441

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

Dinika
Copy link
Contributor

@Dinika Dinika commented Dec 4, 2023

According to this solution to the issue on the github repo of the plugin we use for slack-github notificate, the blocks sub field can be ignored if the SLACK_WEBHOOK_TYPE environment variable is not set.
In this PR I also (try to) enable the uploading of recorded cypress video to the cypress cloud.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2672eb) 48.05% compared to head (22ca26d) 48.00%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1441      +/-   ##
===========================================
- Coverage    48.05%   48.00%   -0.05%     
===========================================
  Files          249      249              
  Lines        11365    11365              
  Branches      2655     2655              
===========================================
- Hits          5461     5456       -5     
- Misses        5870     5876       +6     
+ Partials        34       33       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dinika Dinika force-pushed the improve-slack-notification branch from 4555f59 to 484f9b4 Compare December 11, 2023 11:20
@danburonline danburonline self-requested a review December 12, 2023 08:57
@Dinika Dinika merged commit b8fa139 into develop Dec 12, 2023
1 check passed
@Dinika Dinika deleted the improve-slack-notification branch December 12, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants