Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VS Code settings (debugger, recommended extensions etc.) #1440

Merged
merged 12 commits into from
Jan 10, 2024

Conversation

danburonline
Copy link
Contributor

@danburonline danburonline commented Dec 4, 2023

Small PR to not ignore the .vscode folder in order to include debugger configs and repo extension recommendations. Reason? Especially for the debugger configurations (as we, e.g., also use SSR), to have a higher incentive actually to use the debugger rather than console.log.

Description

  • I also added a .editorconfig file, especially useful for the line endings.
  • Other than that I only applied one default setting for this workspace: to format on save.

How has this been tested?

  • Tested the debugger configs for the attachment in Chrome on my Mac, the same with the Node.js debugger config.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (c238b62) 48.10% compared to head (e23138f) 48.09%.
Report is 23 commits behind head on develop.

Files Patch % Lines
src/shared/containers/ResourceActionsContainer.tsx 11.76% 15 Missing ⚠️
src/shared/components/ResourceActions/index.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1440      +/-   ##
===========================================
- Coverage    48.10%   48.09%   -0.01%     
===========================================
  Files          250      250              
  Lines        11411    11412       +1     
  Branches      2669     2670       +1     
===========================================
  Hits          5489     5489              
- Misses        5888     5889       +1     
  Partials        34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danburonline danburonline marked this pull request as ready for review December 5, 2023 12:53
@danburonline danburonline requested a review from bilalesi December 5, 2023 12:54
@danburonline danburonline changed the base branch from main to develop December 6, 2023 09:58
… chore/add-vs-debugger

# Conflicts:
#	src/shared/containers/ResourceViewActionsContainer.tsx
@danburonline danburonline force-pushed the chore/add-vs-debugger branch 2 times, most recently from c58cad5 to f5f38d5 Compare December 11, 2023 09:35
@danburonline danburonline requested a review from Dinika December 18, 2023 12:10
@danburonline
Copy link
Contributor Author

@Dinika Bilal told me that he doesn't mind adding these things. What about you? Curious to hear your opinion.

@Dinika
Copy link
Contributor

Dinika commented Jan 10, 2024

@Dinika Bilal told me that he doesn't mind adding these things. What about you? Curious to hear your opinion.

Looks great to me. The debugging config in source code actually a good idea :)

@danburonline danburonline merged commit 5fab940 into develop Jan 10, 2024
1 check passed
@danburonline danburonline deleted the chore/add-vs-debugger branch January 10, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants