-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix double-extension on file download #1439
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1439 +/- ##
===========================================
+ Coverage 48.00% 48.08% +0.07%
===========================================
Files 249 249
Lines 11365 11368 +3
Branches 2655 2655
===========================================
+ Hits 5456 5466 +10
+ Misses 5876 5869 -7
Partials 33 33 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job, small comment for covering corner case
Fixes #4529
Description
Before, when you downloaded a single file via the interface, let's say
example.json
, the download window would showexample.json.json
, which is incorrect. With this change, this won't happen again.How has this been tested?
example.json.json
.Types of changes
Checklist: