-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undeprecate resources #1438
Undeprecate resources #1438
Conversation
And clean LESS files, dead code etc.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1438 +/- ##
===========================================
- Coverage 48.08% 48.05% -0.04%
===========================================
Files 249 249
Lines 11368 11390 +22
Branches 2655 2665 +10
===========================================
+ Hits 5466 5473 +7
- Misses 5869 5883 +14
- Partials 33 34 +1 ☔ View full report in Codecov by Sentry. |
Not working yet.
... and state and hide button if it's an old revision.
Works and creates things accordingly. Also, adding a custom generic resource fixture.
Add comments and additional checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work, left some comments
regarding this part:
BlueBrain/nexus#4542: During the development I realised that the UI is quite messy, as it potentially grew organically (Frankenstein UI). This new ticket discusses a potential non-functional redesign.
There is already a design for the Resource details view and we already have a ticket for that
I will share it with you when we get there
src/shared/organisms/DataExplorerGraphFlowContent/DataExplorerGraphFlowContent.tsx
Show resolved
Hide resolved
As it seems that the test runner is too slow.
@bilalesi I see that the tests are still failing (or sometimes fail and sometimes not). Will investigate before merging this. |
As discussed today: Removing this as we either way want to potentially move to Playwright.
… feat/undeprecate-resource # Conflicts: # package.json
Fixes #4509
Description
Major things
ResourceView
component. When clicking on it it updates the states and goes to the latest revision (it's the same flow as when you, e.g. deprecate a resource).Cleaning
package.json
viasort-package-json
=> following common rules.QueryClient
was missing. This is fixed.Additional Tickets Uncovered
ResourceViewContainer
component. This was out of scope for the the current ticket of this PR (#4509)How has this been tested?
Types of changes
Checklist: