Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customization options for start page's background #1437

Merged
merged 42 commits into from
Dec 8, 2023

Conversation

danburonline
Copy link
Contributor

@danburonline danburonline commented Nov 20, 2023

Fixes #3761

Description

  • I have updated the documentation for Nexus and included example screenshots. You can find the pull request here.
  • The background video was implemented, but it did not play in the production version due to an issue with the Webpack configuration. This issue has been fixed.
  • Instead of using a video cover, I have replaced it with a backup image using the source tag. This prevents flickering of the background by loading the image first.
  • The PNG logo on the top left has been replaced with an SVG logo, including fine-tuned adjustments to the spacing.
  • I replaced the logo with the correct version that has the HEX codes from the Fusion codebase, as the previous logo had incorrect colors due to being an old version.
  • I have compressed the images using the Guetzli algorithm, reducing their file size by a few KBs.
  • The background video has been compressed using proper dynamic H264 bitrate compression, resulting in a significantly smaller file size.
    I removed the last two frames of the background video. It appears that they were cut right before another movement, causing slight blur but no movement. The video now loops more smoothly.
  • I have fixed some typos in all the files I worked on.
  • The TypeScript imports have been automatically ordered using my ESLint addon. I am considering adding an ESLint rule for the codebase in the future and transitioning from TSLint to ESLint, as TSLint is deprecated.
  • Markdown errors have been corrected.
  • Alt attributes have been added to the images in the files I worked on.
  • The order of HTML tags on the landing page has been changed to make the logo on the top left clickable and improve loading priorities, with the video being loaded last.
  • Semantic HTML tags have been used instead of <div>.
  • The Connect button now has a different cursor when there are no Realms set up.
  • A lang attribute and read direction have been added to the root HTML, as the Helmet settings were not working.
  • The missing LOGO_LINK environment variable has been set up to make the logo clickable.
  • Ensure that the cover image, background image, and all other banner images do not get squeezed when the browser window is resized. Here's a "before and after" comparison:
    CleanShot 2023-11-23 at 10  27 37

How has this been tested?

  • Tested it locally on my laptop via the development server and prod build. I didn't do any functional changes. Tests pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added screenshots (if applicable), in the comment section.

@danburonline danburonline self-assigned this Nov 20, 2023
@danburonline danburonline changed the title Background image Customization options for start page's background Nov 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5db9678) 47.99% compared to head (b2672eb) 48.05%.
Report is 3 commits behind head on develop.

Files Patch % Lines
src/shared/store/actions/search.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1437      +/-   ##
===========================================
+ Coverage    47.99%   48.05%   +0.05%     
===========================================
  Files          249      249              
  Lines        11362    11365       +3     
  Branches      2655     2655              
===========================================
+ Hits          5453     5461       +8     
+ Misses        5876     5870       -6     
- Partials        33       34       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Due to rendering order, blocking and natural z-index.
Including fixing the Cypress test.
Without visual compression loss and
I also removed the last two frames
as there was an issue with them (the
loop looked off).
Adding `h1` title and `main` tags.
The `htmlAttributes` was empty, also in prod.
As we only have the app in EN, it makes
sense to add it statically in the root HTML(s).
Now, we can click directly on the URL
in the terminal.
Incl. added alt attribute for the images.
I was looking at the colors in
the official logo and couldn't find
it. Therefore I was investigating this
file and cleaned it.
Dinika
Dinika previously approved these changes Nov 28, 2023
Copy link
Contributor

@Dinika Dinika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great too :)

src/pages/IdentityPage/IdentityPage.tsx Outdated Show resolved Hide resolved
src/pages/IdentityPage/styles.less Outdated Show resolved Hide resolved
src/server/index.tsx Show resolved Hide resolved
Copy link
Contributor

@bilalesi bilalesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice PR 🎆

src/server/index.tsx Outdated Show resolved Hide resolved
src/server/silent_refresh.ts Show resolved Hide resolved
@olivergrabinski
Copy link

Ensure that the cover image, background image, and all other banner images do not get squeezed when the browser window is resized. Here's a "before and after" comparison

🤩

@danburonline danburonline changed the base branch from main to develop December 6, 2023 09:12
… feature/org-welcome-page-bg

# Conflicts:
#	src/shared/containers/ResourceViewActionsContainer.tsx
@danburonline danburonline merged commit 9b927a0 into develop Dec 8, 2023
1 check passed
@danburonline danburonline deleted the feature/org-welcome-page-bg branch December 8, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants