Skip to content

Commit

Permalink
Fix styling
Browse files Browse the repository at this point in the history
  • Loading branch information
danburonline committed Dec 11, 2023
1 parent dda212f commit 5319582
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
4 changes: 3 additions & 1 deletion src/shared/components/ResourceEditor/ResourceEditor.less
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
// .cm-s-base16-light span.cm-string {
// }

// get button with class .cancel
button.cancel {
margin-right: 5px;
}
Expand Down Expand Up @@ -56,13 +55,16 @@ button.cancel {
background-color: #f0efef;
padding: @default-pad;
height: 52px;
white-space: nowrap;
}

._positive {
margin-right: 1rem;
color: @success-color;
}

._negative {
margin-right: 1rem;
color: @error-color;
}

Expand Down
9 changes: 4 additions & 5 deletions src/shared/components/ResourceEditor/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ import { useEditorPopover, useEditorTooltip } from './useEditorTooltip';

export interface ResourceEditorProps {
rawData: { [key: string]: any };
onSubmit: (rawData: { [key: string]: any }) => void;
onFormatChange?(expanded: boolean): void;
onMetadataChange?(expanded: boolean): void;
editable?: boolean;
editing?: boolean;
busy?: boolean;
Expand All @@ -39,6 +36,9 @@ export interface ResourceEditorProps {
projectLabel: string;
showFullScreen: boolean;
showControlPanel?: boolean;
onSubmit: (rawData: { [key: string]: any }) => void;
onFormatChange?(expanded: boolean): void;
onMetadataChange?(expanded: boolean): void;
onFullScreen(): void;
}

Expand Down Expand Up @@ -185,7 +185,7 @@ const ResourceEditor: React.FC<ResourceEditorProps> = props => {
<div className="control-panel">
{editable && isEditing && valid && !lintError && (
<div className="feedback _positive">
<CheckCircleOutlined /> Valid JSON-LD
<CheckCircleOutlined /> Valid
</div>
)}
{editable && isEditing && !valid && (
Expand All @@ -196,7 +196,6 @@ const ResourceEditor: React.FC<ResourceEditorProps> = props => {
{editable && isEditing && lintError && (
<div className="feedback _negative">
{/* TODO Get lint error from custom linter */}
{/* TODO Fix styling */}
<ExclamationCircleOutlined /> Cannot have fields starting with an
underscore
</div>
Expand Down

0 comments on commit 5319582

Please sign in to comment.