Skip to content

feat(notifications): include task name in approval needed notification #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LSRCT merged 1 commit into from
Jan 12, 2026
+7 −3
Merged

feat(notifications): include task name in approval needed notification #1879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions crates/services/src/services/approvals/executor_approvals.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use std::sync::Arc;

use async_trait::async_trait;
use db::{self, DBService};
use db::{self, DBService, models::execution_process::ExecutionProcess};
use executors::approvals::{ExecutorApprovalError, ExecutorApprovalService};
use serde_json::Value;
use utils::approvals::{ApprovalRequest, ApprovalStatus, CreateApprovalRequest};
Expand Down Expand Up @@ -57,10 +57,14 @@ impl ExecutorApprovalService for ExecutorApprovalBridge {
.await
.map_err(ExecutorApprovalError::request_failed)?;

// Play notification sound when approval is needed
let task_name = ExecutionProcess::load_context(&self.db.pool, self.execution_process_id)
.await
.map(|ctx| ctx.task.title)
.unwrap_or_else(|_| "Unknown task".to_string());

self.notification_service
.notify(
"Approval Needed",
&format!("Approval Needed: {}", task_name),
&format!("Tool '{}' requires approval", tool_name),
)
.await;
Expand Down