Fix GitHub Enterprise URL parsing in review crate (Vibe Kanban) #1784
+36
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review CompleteYour review story is ready! Comment !reviewfast on this PR to re-generate the story. |
LSRCT
changed the title
LSRCT
force-pushed
the
vk/e220-support-hosted-g
branch
from
ee8ebd3 to
f1e4e7b
Compare
LSRCT
force-pushed
the
vk/4afe-gh-url-parsing-f
branch
from
13f6c77 to
328b9ae
Compare
## Summary I've successfully fixed the GitHub Enterprise URL parsing issue in the `crates/review/` crate by delegating URL parsing to the `gh` CLI instead of manually parsing URLs. ### Changes Made 1. **`crates/review/src/github.rs`**: - Removed the `parse_pr_url()` function that had hardcoded `"github.com"` check - Added `GhRepoOwner` and `GhRepo` structs to parse repository info from `gh` response - Updated `GhPrView` struct to include `head_repository` field - Modified `get_pr_info()` to accept the raw PR URL and extract owner/repo from the `gh pr view` JSON response - Removed unit tests for `parse_pr_url()` (no longer needed) 2. **`crates/review/src/main.rs`**: - Removed import of `parse_pr_url` - Simplified the flow: now just calls `get_pr_info(&args.pr_url)` directly - Uses `pr_info.owner` and `pr_info.repo` from the response - Updated step numbers in comments 3. **`crates/review/src/error.rs`**: - Removed `InvalidPrUrl` error variant (no longer needed since `gh` handles URL validation) ### How It Works Now Instead of: ```rust let (owner, repo, pr_number) = parse_pr_url(&args.pr_url)?; // Hardcoded github.com check let pr_info = get_pr_info(&owner, &repo, pr_number)?; ``` The new flow is: ```rust let pr_info = get_pr_info(&args.pr_url)?; // gh CLI handles all URL parsing // pr_info.owner and pr_info.repo are extracted from gh response ``` This approach: - Eliminates hardcoded hostname checks - Supports GitHub Enterprise instances automatically - Supports SSH hostname aliases from `~/.ssh/config` - Matches the pattern used in `crates/services/` - Lets `gh` handle authentication for different GitHub hosts
1. Removed `/// Repository owner info from \`gh pr view --json\`` (line 20) 2. Removed `/// Repository info from \`gh pr view --json\`` (line 26) 3. Removed the multi-line doc comment for `get_pr_info`: - `/// Get PR information using \`gh pr view\` with the raw URL` - `///` - `/// This accepts any GitHub PR URL (including GitHub Enterprise) and lets \`gh\`` - `/// handle the hostname resolution and authentication.`
…sitoryOwner` as separate fields, not nested. Try running it again: ```bash cargo run -p review -- #1 ```
LSRCT
force-pushed
the
vk/4afe-gh-url-parsing-f
branch
from
328b9ae to
3f8055a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
github.comURL parsing in thereviewCLI crateghCLI which handles GitHub Enterprise hostnames automaticallyheadRepositoryandheadRepositoryOwnerfieldsWhat changed
crates/review/src/github.rsparse_pr_url()function that had hardcodedgithub.comcheckget_pr_info()to accept raw PR URL and pass it directly togh pr viewGhRepoOwnerandGhRepostructs to parse theghCLI JSON response correctlyheadRepositoryOwner.loginandheadRepository.namefieldscrates/review/src/main.rsget_pr_info(&args.pr_url)directly instead of parsing URL firstpr_info.ownerandpr_info.repofrom theghresponsecrates/review/src/error.rsInvalidPrUrlerror variantWhy
GitHub Enterprise instances use different hostnames (e.g.,
github.mycompany.com). The previous implementation rejected any URL that didn't containgithub.com, breaking GHE support.By delegating to the
ghCLI, we get automatic support for:~/.ssh/configTesting
This PR was written using Vibe Kanban