-
Notifications
You must be signed in to change notification settings - Fork 44
feat(groq): Migrate Groq to v2 Plugins API #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
HassanBahati
wants to merge
14
commits into
BloomLabsInc:main
Choose a base branch
from
HassanBahati:@invertase/migrate-groq-to-V2plugins-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
88ec1da
chore(groq): bump genkit version
HassanBahati 288ffcd
feat: migrate to v2 plugins API
HassanBahati 941fd63
chore(plugins/groq): remove /groq prefix
HassanBahati 1a8afdb
chore(plugins/groq): remove unnecessary comments
HassanBahati 533f1d2
chore(plugins/groq): add name and namespace
HassanBahati bab5c8c
chore(plugins/groq): format
HassanBahati 1087bad
tests(plugins/groq): test for namespace to be groq when listing avail…
HassanBahati 6c8cfd6
Merge branch 'BloomLabsInc:main' into @invertase/migrate-groq-to-V2pl…
HassanBahati 57b7886
test(js/plugin/groq): setup jest tests
HassanBahati 7785060
test(js/plugin/groq): add plugin standalone tests
HassanBahati e4e689e
test(js/plugins/groq): implement resolve method and add standalone tests
HassanBahati 666aef6
chore(js/plugins/groq): cleanup
HassanBahati cc536d0
refactor(js/plugins/groq): replace loop with push to a map
HassanBahati d090f09
tests(js/plugins/groq): clear mocks before test suits
HassanBahati File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the
groq/part?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well,
groq/was initially being appended to the model name.The prefix groq/ was added here:
https://github.com/BloomLabsInc/genkit-plugins/pull/9/files#diff-9c9efbee9ae1c4a79760d6d2d0f89c9d46d538f645235c21e3f51f3c4c9e35aeR454-R457
When the initialized Genkit object is logged while using the
genkitx-groqpackage (which has the v1 plugin under the hood), the resulting model name will include this prefix.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary anymore in v2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, removing it shortly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HassanBahati I think we're going for
namespace: 'pluginName'andname: 'modelName'instead. So can we apply that here and to your other migrations too.For example:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CorieW, i've updated