Add state commitments to simplicity info and simplictiy pset update-input
#33
+73
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
force-pushed
the
2025-12/state
branch
from
21b4452 to
7e16364
Compare
Does this mean that it actually breaks existing uses of |
Contributor
Author
|
No, existing uses will continue to work. It's only if you're trying to use state, but do so incorrectly or incompletely, that the UX has some footguns. I will file an issue with some suggestions. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not include documentation, tutorials or extended unit tests. I believe that this is not discoverable. But it is better that it exist than not, so I'm PR'ing it as-is.
In short:
-s <state as 32-byte hex>flag tosimplicity infowhich tweaks the generated addresses/scriptpubkeys accordingly-s <state as 32-byte hex>flag tosimplicity pset update-inputwhich creates a two-leaf taptree rather than a one-leaf one when computing control blocksIf you fail to provide these, in both cases the command will just silently produce output you didn't intend.