Feature Export OTP as Secret or QR code #252
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Austin-Fulbright
force-pushed
the
feature_export_otp
branch
from
e3a59c0 to
ea1d501
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature will allow users to export their OTP uri as a qrcode. They will also be able to view the Secret Key in a seperate screen similar to the address viewer.
NOTE: There is a lot of borrowed and refactored code in this change. Also I might want a more secure way to view the secret key (for instance giving warnings to the user before they view, or having some kind of sensitive data that can be read on the screen but is encrypted on the backend). Let me know what your thoughts are on the security of this change.