feat(web): get Env from API endpoint #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d80e5ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
xFJA
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
==========================================
+ Coverage 88.57% 88.81% +0.23%
==========================================
Files 162 163 +1
Lines 11060 11073 +13
Branches 1208 1208
==========================================
+ Hits 9796 9834 +38
+ Misses 1264 1239 -25 ☔ View full report in Codecov by Sentry. |
📦 Next.js Bundle Analysis for @blobscan/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
xFJA
requested review from
PabloCastellano,
luis-herasme and
PJColombo
and removed request for
PabloCastellano and
luis-herasme
PJColombo
requested changes
Jan 21, 2025
luis-herasme
approved these changes
Jan 28, 2025
Merged
luis-herasme
pushed a commit
that referenced
this pull request
Feb 24, 2025
* feat(web): fetch env from API endpoint in client side * feat(web): adapt server side sentry env config for any environment * fix(web): limit to '1' env query * refactor(web): reset 'server' and 'edge' sentry config * refactor(web): move env endpoint from API package to Next API * feat: remove default env value * feat(web): use Next env api endpoint to init sentry in clientside * chore(web): remove unnecessary export * refactor(web): remove unnecessary env fetch utils file * feat(web): validate env API request json parsing * chore(web): update changeset * refactor(web): infer clien env zod schema in Env provider * feat(web): update client vars schema * feat(web): update client env var references after name refactor * style(web): type provider env vars * chore: update `pnpm-lock` * chore(web): remove `NEXT` prefix env vars * chore(web): parse env vars fetched from api * chore(web): use type casting instead of Zod schema parsing on client as env vars are already parsed on the server * chore(web): fix blobscan version info --------- Co-authored-by: PJColombo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
The environment variables on the client side are now obtained from an
apiendpoint when the app initializes. This way, you should be able to change their values without redeploying for future deployment changes.Related Issue (Optional)
Closes #87