feat(web): Create category filter #637
Conversation
🦋 Changeset detectedLatest commit: 55b013a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
📦 Next.js Bundle Analysis for @blobscan/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
332.39 KB (🔴 +86.77 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
New Pages Added
The following pages were added to the bundle from the code in this PR:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/block_neighbor |
251 B |
332.63 KB | 95.04% |
/stats |
348.07 KB |
680.46 KB | 194.42% |
Eight Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/ |
354.57 KB |
686.96 KB | 196.27% (🟢 -4.22%) |
/address/[address] |
29.89 KB |
362.28 KB | 103.51% (🟢 -3.96%) |
/blob/[hash] |
29.67 KB |
362.06 KB | 103.45% (🟢 -3.65%) |
/blobs |
80.74 KB |
413.13 KB | 118.04% (🟡 +13.69%) |
/block/[id] |
15.06 KB |
347.45 KB | 99.27% (🟢 -3.95%) |
/blocks |
78.48 KB |
410.87 KB | 117.39% (🟡 +13.69%) |
/tx/[hash] |
17.54 KB |
349.93 KB | 99.98% (🟡 +1.22%) |
/txs |
77.9 KB |
410.29 KB | 117.23% (🟡 +11.65%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
Category filter allows to filter all the items that doesn't have a rollup related
I agree with setting ‘Rollup’ as the default, but I’d prefer to keep the sorting alphabetical. |
| @@ -214,6 +221,11 @@ export const withFilters = t.middleware(({ next, input = {} }) => { | |||
| filters.transactionCategory = "ROLLUP"; | |||
| } | |||
|
|
|||
| filters.transactionCategory = | |||
There was a problem hiding this comment.
Is there any particular reason we allow null for category values? I’d prefer restricting it to just the enum values.
|
Additionally, when I first navigate to any of the table pages, the category filter is set, but the route does not contain the corresponding query parameter. 
|
|
Finall
Finally, we have agreed to avoid set a default value for the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
==========================================
- Coverage 88.77% 88.72% -0.05%
==========================================
Files 159 158 -1
Lines 10865 10872 +7
Branches 1203 1201 -2
==========================================
+ Hits 9645 9646 +1
- Misses 1220 1226 +6 ☔ View full report in Codecov by Sentry. |
xFJA
force-pushed
the
create-category-filter
branch
from
238b9a2 to
9e6b037
Compare
Checklist
Description
IT BUILDS ON TOP OF #623
A new filter has been added:
Category:Rollupdropdown filter is disabledwebthenoneoption in theRollupfilter as we can achieve that with the current filterRelated Issue
Closes #594
Screenshots
Screen.Recording.2024-11-21.at.11.37.55.mov