Skip to content

chore: v3.7.0 release prep — docs, version bump, changelog#511

Open
Blb3D wants to merge 1 commit intomainfrom
docs/v370-release
Open

chore: v3.7.0 release prep — docs, version bump, changelog#511
Blb3D wants to merge 1 commit intomainfrom
docs/v370-release

Conversation

@Blb3D
Copy link
Copy Markdown
Owner

@Blb3D Blb3D commented Apr 6, 2026

Summary

  • VERSION bump: 3.6.0 → 3.7.0
  • CHANGELOG entry documenting all changes since v3.6.0
  • Reference docs regenerated (API, Schema, Migrations)
  • User guide updated with new v3.7.0 workflows

Docs changes

Doc Change
API-REFERENCE.md Regenerated — 432 → 438 endpoints (6 new)
SCHEMA-REFERENCE.md Regenerated — migrations 074-077 included
MIGRATIONS-LOG.md Regenerated — 56 → 60 migrations
FEATURE-CATALOG.md 41 → 50 features; new v3.7.0 sections
user-guide/orders.md Added: Line Editing, Line Removal, Close-Short sections
user-guide/production.md Added: Accept-Short, Refresh Routing sections
workflows/quote-to-cash.md Added: Step 5b — Handle Production Shortfall
496-architecture-review.md Removed (stale planning doc, was never tracked)

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes – v3.7.0

  • New Features

    • Added order line editing with reason tracking and guarded removal
    • Introduced order close-short workflow for partial fulfillment acceptance
    • Added production order accept-short and refresh-routing capabilities
    • Redesigned quote, invoice, and packing slip PDFs
    • Added admin direct messaging feature
  • Bug Fixes

    • Pending orders are now editable
    • Corrected quote source attribution in converted orders
    • Fixed schema constraint preventing order conversions
    • Improved packing slip layout spacing
    • Enhanced close-short state clarity and multi-line order summaries
  • Documentation

    • Updated API reference with new endpoints
    • Added user guides for new order and production workflows
    • Updated feature catalog and migration documentation

- VERSION: 3.6.0 → 3.7.0
- CHANGELOG: document 9 new features and 5 fixes since v3.6.0
- Regenerated API-REFERENCE.md (432→438 endpoints), SCHEMA-REFERENCE.md
  (64 models), MIGRATIONS-LOG.md (56→60 migrations)
- FEATURE-CATALOG.md: 41→50 features, add v3.7.0 sections
- user-guide/orders.md: add line editing, line removal, close-short sections
- user-guide/production.md: add accept-short, refresh-routing sections
- workflows/quote-to-cash.md: add production shortfall path (Step 5b)
- Remove stale docs/496-architecture-review.md (was never tracked)

Co-authored-by: Claude <[email protected]>
Agent-Session: v370-release-docs-20260406
Copilot AI review requested due to automatic review settings April 6, 2026 06:07
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026

Walkthrough

Release documentation update for version 3.7.0 with changelog entries, version bump, regenerated API/schema reference documents, feature catalog expansion, and new user-guide sections documenting close-short and order line editing workflows.

Changes

Cohort / File(s) Summary
Release Metadata
CHANGELOG.md, backend/VERSION
Version bumped to 3.7.0 with release notes documenting new order-editing/manufacturing workflows (line editing, close-short accepting partial fulfillment, PO accept-short, routing refresh), redesigned PDFs, admin messaging, and assorted bug fixes in pending-order editability, quote-converted order sourcing, schema constraints, and UI clarity.
API & Schema Reference
docs/API-REFERENCE.md, docs/FEATURE-CATALOG.md, docs/MIGRATIONS-LOG.md, docs/SCHEMA-REFERENCE.md
Updated endpoint counts (432→438), added four new ADMIN sales-order routes and two new CUSTOMER production-order routes, expanded feature catalog from 41→50 features with v3.7.0 sections, logged four new migrations (074–077) adding close-short fields, fulfillment status tracking, and close-short record tables, and updated schema with nullable unit prices and new table definitions.
User Guide Documentation
docs/user-guide/orders.md, docs/user-guide/production.md, docs/user-guide/workflows/quote-to-cash.md
Added comprehensive workflow guides for editing/removing order lines with reason tracking, closing orders short with partial fulfillment acceptance, refreshing production order routing, and handling production shortfalls in the quote-to-cash workflow with per-line achievable quantities preview.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

Docs aligned, versioned with care, 🚀
New workflows gently laid bare,
Line edits, short closes, and more,
Three-point-seven opens the door! 📋✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the primary changes: version bump, changelog update, and documentation regeneration for the v3.7.0 release.
Description check ✅ Passed The description covers the template's required sections: summary (bullet points), related docs changes table, but omits Testing checklist and the standard PR checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/v370-release

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

Review Council Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit d9e581f.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prepares the v3.7.0 release by bumping the backend version and updating/regenerating the documentation set (API, schema, migrations, feature catalog, and user guides) to reflect newly added sales/production workflows.

Changes:

  • Bump backend version to 3.7.0 and add a v3.7.0 CHANGELOG entry.
  • Regenerate reference docs (API/schema/migrations) and expand feature catalog counts/features.
  • Update user guides with new workflows (close-short, line editing/removal, accept-short, refresh-routing, production shortfall path).

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
docs/user-guide/workflows/quote-to-cash.md Adds optional “production shortfall” step and updates the checklist accordingly.
docs/user-guide/production.md Documents Accept Short and Refresh Routing workflows; adds quick-reference entries.
docs/user-guide/orders.md Documents order line editing/removal and close-short workflow; adds quick-reference entries.
docs/SCHEMA-REFERENCE.md Regenerated schema reference reflecting new models/fields (e.g., close-short fields, CloseShortRecord).
docs/MIGRATIONS-LOG.md Regenerated migrations log including migrations 074–077 and updated totals.
docs/FEATURE-CATALOG.md Expands feature catalog (41 → 50) with v3.7.0 feature sections and updated metadata.
docs/API-REFERENCE.md Regenerated API reference reflecting new endpoints and updated endpoint counts.
CHANGELOG.md Adds v3.7.0 release notes (Added/Fixed/Documentation).
backend/VERSION Version bump from 3.6.0 to 3.7.0.
Comments suppressed due to low confidence (2)

docs/API-REFERENCE.md:982

  • API reference footer still says Generated for FilaOps Core v3.6.0 while this PR is preparing the v3.7.0 release. Update the generated version string so consumers don’t misinterpret the doc as being for the previous release.

*Last updated: 2026-04-06*
*Generated for FilaOps Core v3.6.0*

docs/MIGRATIONS-LOG.md:1333

  • Migrations log footer still says Generated for FilaOps Core v3.6.0 even though the overview/migrations list includes new 074–077 changes for the v3.7.0 release. Update the generated version string to match the release/version bump.

*Last updated: 2026-04-06*
*Generated for FilaOps Core v3.6.0*


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


**Generated:** 2026-03-30
**Generated:** 2026-04-06
**Source:** FilaOps Core v3.6.0
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema reference header still says Source: FilaOps Core v3.6.0 even though this PR bumps the release to 3.7.0 and regenerates the schema. Update the source version (or ensure the generator pulls from backend/VERSION) so the doc matches the release being prepared.

Suggested change
**Source:** FilaOps Core v3.6.0
**Source:** FilaOps Core v3.7.0

Copilot uses AI. Check for mistakes.
Comment on lines +336 to +337
---

Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two consecutive horizontal rules (---) here, which renders as an unnecessary extra separator. Remove one of them to keep the markdown structure clean.

Suggested change
---

Copilot uses AI. Check for mistakes.
Comment on lines +451 to +452
---

Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two consecutive horizontal rules (---) before the new "Editing Order Lines" section. Remove the duplicate separator to avoid redundant markdown output.

Suggested change
---

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 8

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@CHANGELOG.md`:
- Line 22: The release note incorrectly states the PRO gate uses an isPro
feature flag; update the wording to reflect the actual implementation which
gates admin-initiated direct messaging based on the derived 'n' value from
'tier' (e.g., "professional" or "enterprise") instead of an isPro flag—adjust
the line that currently mentions "isPro" so it references gating by 'tier'/'n'
(professional|enterprise) or similar phrasing that matches the frontend logic.
- Line 10: The CHANGELOG has a new heading "## [3.7.0]" but the link-reference
footer still stops at "3.4.0" and the "[Unreleased]" compare target is stale;
update the link-reference block at the bottom to add a reference for "3.7.0"
(pointing to the appropriate GitHub compare URL or tag) and change the
"[Unreleased]" URL to compare from "v3.6.0" (or the correct previous release) to
HEAD so the "## [3.7.0]" heading resolves as a clickable compare link and
Unreleased compares from the correct prior tag.

In `@docs/API-REFERENCE.md`:
- Around line 980-981: The API reference footer currently hardcodes the old
release string "v3.6.0"; update that footer string to "v3.7.0" so the generated
docs match the new endpoints (replace the literal "v3.6.0" found in the footer
text with "v3.7.0").

In `@docs/FEATURE-CATALOG.md`:
- Around line 233-235: Remove the duplicated footer by keeping a single
canonical metadata block and deleting the redundant line; specifically locate
the footer strings "*Last updated: 2026-04-06*", "*Generated for FilaOps Core
v3.7.0*" and the older "*Generated for FilaOps Core (Open Source)*" and remove
the older/generic "*Generated for FilaOps Core (Open Source)*" so only the
versioned generation metadata remains.

In `@docs/MIGRATIONS-LOG.md`:
- Around line 1331-1332: Update the generated footer string that currently reads
"FilaOps Core v3.6.0" to reflect the new release version "FilaOps Core v3.7.0"
(the line containing the footer version text near the "Last updated" timestamp).

In `@docs/SCHEMA-REFERENCE.md`:
- Around line 5-7: The schema header in docs/SCHEMA-REFERENCE.md is out of sync:
replace the header line "Source: FilaOps Core v3.6.0" with "Source: FilaOps Core
v3.7.0" so the document accurately reflects the included 3.7.0 schema additions
(e.g., close-short artifacts); locate the header block containing
"**Generated:**", "**Source:** FilaOps Core v3.6.0", and "**Total Models:**" and
update the Source version string accordingly.

In `@docs/user-guide/orders.md`:
- Around line 455-456: The docs incorrectly state that admins can remove lines
in "pending" — server-side removal is implemented only for confirmed,
in_production, and on_hold (see sales_orders endpoint and sales_order_service
implementations); update the sentence in the user-guide to remove "pending" from
the list (or split into two clauses clarifying that quantity edits may be
allowed in pending but line removal is limited to confirmed, in_production, and
on_hold) so the doc matches the backend behavior.
- Around line 469-476: The docs text currently says "No active production
orders" which understates the backend guard (it blocks removal if any
non-cancelled production order exists, including completed/closed states);
update the wording in the order line removal section by replacing the phrase "No
active production orders" with "No non-cancelled production orders (including
completed/closed)" and change the note "If a production order exists for the
line, cancel it first before removing the line." to explicitly state "If any
non-cancelled production order (including completed/closed states) exists for
the line, cancel it first before removing the line." so the guide matches the
stricter backend behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2eae7434-3f34-4387-96f3-78162f4dfc6b

📥 Commits

Reviewing files that changed from the base of the PR and between 1a28385 and d9e581f.

📒 Files selected for processing (9)
  • CHANGELOG.md
  • backend/VERSION
  • docs/API-REFERENCE.md
  • docs/FEATURE-CATALOG.md
  • docs/MIGRATIONS-LOG.md
  • docs/SCHEMA-REFERENCE.md
  • docs/user-guide/orders.md
  • docs/user-guide/production.md
  • docs/user-guide/workflows/quote-to-cash.md


## [Unreleased]

## [3.7.0] - 2026-04-06
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Add release link references for 3.7.0 (and update Unreleased compare target)

You introduced ## [3.7.0] but the link-reference block still stops at 3.4.0, so the new heading won’t resolve as a clickable compare link. Also, [Unreleased] still compares from v3.4.0, which is now stale.

Suggested footer patch
-[Unreleased]: https://github.com/Blb3D/filaops/compare/v3.4.0...HEAD
+[Unreleased]: https://github.com/Blb3D/filaops/compare/v3.7.0...HEAD
+[3.7.0]: https://github.com/Blb3D/filaops/compare/v3.6.0...v3.7.0
+[3.6.0]: https://github.com/Blb3D/filaops/compare/v3.5.0...v3.6.0
+[3.5.0]: https://github.com/Blb3D/filaops/compare/v3.4.0...v3.5.0
 [3.4.0]: https://github.com/Blb3D/filaops/compare/v3.3.0...v3.4.0

Tiny fix, big clickability. TARS approves efficient trajectories.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@CHANGELOG.md` at line 10, The CHANGELOG has a new heading "## [3.7.0]" but
the link-reference footer still stops at "3.4.0" and the "[Unreleased]" compare
target is stale; update the link-reference block at the bottom to add a
reference for "3.7.0" (pointing to the appropriate GitHub compare URL or tag)
and change the "[Unreleased]" URL to compare from "v3.6.0" (or the correct
previous release) to HEAD so the "## [3.7.0]" heading resolves as a clickable
compare link and Unreleased compares from the correct prior tag.

- **Quote PDF redesign** — professional B2B layout with brand colors, two-column header, itemized lines, and terms (#497)
- **Invoice PDF redesign** — professional layout with full customer info, payment terms, calculated due date, and packing slip match (#504)
- **Packing slip redesign** — matches invoice/quote style with brand header, dark table header, and alternating row stripes (#504)
- **Admin messaging** — admin-initiated direct messaging (PRO-gated with `isPro` feature flag) (#493)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

isPro wording doesn’t match the current implementation

This line says PRO gating uses an isPro feature flag, but the provided frontend code gates on n derived from tier (professional|enterprise), not a flag named isPro. Suggest rewording to avoid drift in release notes.

Suggested wording tweak
-- **Admin messaging** — admin-initiated direct messaging (PRO-gated with `isPro` feature flag) (`#493`)
+- **Admin messaging** — admin-initiated direct messaging (PRO-tier gated in UI) (`#493`)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- **Admin messaging** — admin-initiated direct messaging (PRO-gated with `isPro` feature flag) (#493)
- **Admin messaging** — admin-initiated direct messaging (PRO-tier gated in UI) (`#493`)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@CHANGELOG.md` at line 22, The release note incorrectly states the PRO gate
uses an isPro feature flag; update the wording to reflect the actual
implementation which gates admin-initiated direct messaging based on the derived
'n' value from 'tier' (e.g., "professional" or "enterprise") instead of an isPro
flag—adjust the line that currently mentions "isPro" so it references gating by
'tier'/'n' (professional|enterprise) or similar phrasing that matches the
frontend logic.

Comment on lines +980 to 981
*Last updated: 2026-04-06*
*Generated for FilaOps Core v3.6.0*
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

API reference footer still points to previous release.

Line 981 says v3.6.0 despite this document including new 3.7.0 endpoints. Please update to keep generated docs internally consistent.

Suggested fix
 *Last updated: 2026-04-06*
-*Generated for FilaOps Core v3.6.0*
+*Generated for FilaOps Core v3.7.0*
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
*Last updated: 2026-04-06*
*Generated for FilaOps Core v3.6.0*
*Last updated: 2026-04-06*
*Generated for FilaOps Core v3.7.0*
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/API-REFERENCE.md` around lines 980 - 981, The API reference footer
currently hardcodes the old release string "v3.6.0"; update that footer string
to "v3.7.0" so the generated docs match the new endpoints (replace the literal
"v3.6.0" found in the footer text with "v3.7.0").

Comment on lines +233 to 235
*Last updated: 2026-04-06*
*Generated for FilaOps Core v3.7.0*
*Generated for FilaOps Core (Open Source)*
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Footer metadata is now duplicated/inconsistent.

Line 234 already includes versioned generation metadata, but Line 235 leaves an older generic footer in place. Keep one canonical footer to avoid “which one is authoritative?” archaeology later.

Suggested cleanup
 *Last updated: 2026-04-06*  
 *Generated for FilaOps Core v3.7.0*
-*Generated for FilaOps Core (Open Source)*
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
*Last updated: 2026-04-06*
*Generated for FilaOps Core v3.7.0*
*Generated for FilaOps Core (Open Source)*
*Last updated: 2026-04-06*
*Generated for FilaOps Core v3.7.0*
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/FEATURE-CATALOG.md` around lines 233 - 235, Remove the duplicated footer
by keeping a single canonical metadata block and deleting the redundant line;
specifically locate the footer strings "*Last updated: 2026-04-06*", "*Generated
for FilaOps Core v3.7.0*" and the older "*Generated for FilaOps Core (Open
Source)*" and remove the older/generic "*Generated for FilaOps Core (Open
Source)*" so only the versioned generation metadata remains.

Comment on lines +1331 to 1332
*Last updated: 2026-04-06*
*Generated for FilaOps Core v3.6.0*
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Generated version footer is stale.

Line 1332 still says v3.6.0 even though this file now documents migrations through 077 for the 3.7.0 release. Please update the footer to keep release metadata consistent.

Suggested fix
 *Last updated: 2026-04-06*
-*Generated for FilaOps Core v3.6.0*
+*Generated for FilaOps Core v3.7.0*
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
*Last updated: 2026-04-06*
*Generated for FilaOps Core v3.6.0*
*Last updated: 2026-04-06*
*Generated for FilaOps Core v3.7.0*
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/MIGRATIONS-LOG.md` around lines 1331 - 1332, Update the generated footer
string that currently reads "FilaOps Core v3.6.0" to reflect the new release
version "FilaOps Core v3.7.0" (the line containing the footer version text near
the "Last updated" timestamp).

Comment on lines +5 to +7
**Generated:** 2026-04-06
**Source:** FilaOps Core v3.6.0
**Total Models:** 63 (Core only)
**Total Models:** 64 (Core only)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Schema header source version is out of sync.

Line 6 still reports FilaOps Core v3.6.0 while this document includes 3.7.0 schema additions (e.g., close-short artifacts). Update the source version to prevent confusion during audits.

Suggested fix
 **Generated:** 2026-04-06
-**Source:** FilaOps Core v3.6.0
+**Source:** FilaOps Core v3.7.0
 **Total Models:** 64 (Core only)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
**Generated:** 2026-04-06
**Source:** FilaOps Core v3.6.0
**Total Models:** 63 (Core only)
**Total Models:** 64 (Core only)
**Generated:** 2026-04-06
**Source:** FilaOps Core v3.7.0
**Total Models:** 64 (Core only)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/SCHEMA-REFERENCE.md` around lines 5 - 7, The schema header in
docs/SCHEMA-REFERENCE.md is out of sync: replace the header line "Source:
FilaOps Core v3.6.0" with "Source: FilaOps Core v3.7.0" so the document
accurately reflects the included 3.7.0 schema additions (e.g., close-short
artifacts); locate the header block containing "**Generated:**", "**Source:**
FilaOps Core v3.6.0", and "**Total Models:**" and update the Source version
string accordingly.

Comment on lines +455 to +456
Admins can edit line quantities and remove lines on orders in **pending**, **confirmed**, **in_production**, or **on_hold** status.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Editable status list overstates line-removal eligibility.

Line 455 includes pending, but server-side line removal is documented/implemented for confirmed, in_production, and on_hold (see backend/app/api/v1/endpoints/sales_orders.py:850-871 and backend/app/services/sales_order_service.py:1367-1435). This mismatch will send admins on a UI scavenger hunt for buttons that won’t exist.

Suggested wording adjustment
-Admins can edit line quantities and remove lines on orders in **pending**, **confirmed**, **in_production**, or **on_hold** status.
+Admins can edit line quantities and remove lines on orders in **confirmed**, **in_production**, or **on_hold** status.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Admins can edit line quantities and remove lines on orders in **pending**, **confirmed**, **in_production**, or **on_hold** status.
Admins can edit line quantities and remove lines on orders in **confirmed**, **in_production**, or **on_hold** status.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/user-guide/orders.md` around lines 455 - 456, The docs incorrectly state
that admins can remove lines in "pending" — server-side removal is implemented
only for confirmed, in_production, and on_hold (see sales_orders endpoint and
sales_order_service implementations); update the sentence in the user-guide to
remove "pending" from the list (or split into two clauses clarifying that
quantity edits may be allowed in pending but line removal is limited to
confirmed, in_production, and on_hold) so the doc matches the backend behavior.

Comment on lines +469 to +476
- The order has more than one line
- The line has not been shipped
- No active production orders are linked to that line

Click **✕** → confirm the prompt → the line is removed and totals recalculate automatically.

> **Note**: If a production order exists for the line, cancel it first before removing the line.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

“No active production orders” is too weak for actual guard behavior.

Lines 471 and 475 imply only active POs block removal, but backend logic blocks removal when any non-cancelled PO exists for the line (including completed/closed states in current service comments). The guide should match that stricter rule to avoid false expectations.

Suggested wording adjustment
-- No active production orders are linked to that line
+- No non-cancelled production orders are linked to that line
...
-> **Note**: If a production order exists for the line, cancel it first before removing the line.
+> **Note**: Line removal is blocked if any non-cancelled production order exists for that line.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- The order has more than one line
- The line has not been shipped
- No active production orders are linked to that line
Click **** → confirm the prompt → the line is removed and totals recalculate automatically.
> **Note**: If a production order exists for the line, cancel it first before removing the line.
- The order has more than one line
- The line has not been shipped
- No non-cancelled production orders are linked to that line
Click **** → confirm the prompt → the line is removed and totals recalculate automatically.
> **Note**: Line removal is blocked if any non-cancelled production order exists for that line.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/user-guide/orders.md` around lines 469 - 476, The docs text currently
says "No active production orders" which understates the backend guard (it
blocks removal if any non-cancelled production order exists, including
completed/closed states); update the wording in the order line removal section
by replacing the phrase "No active production orders" with "No non-cancelled
production orders (including completed/closed)" and change the note "If a
production order exists for the line, cancel it first before removing the line."
to explicitly state "If any non-cancelled production order (including
completed/closed states) exists for the line, cancel it first before removing
the line." so the guide matches the stricter backend behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants