Repository navigation
feat(tui): error dismiss, quick question selection, contextual Blue footer, UI cleanup - #1039
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed5baa4620
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // The option list is numbered in the UI; accept the same number keys | ||
| // for quick selection without changing the arrow-key flow. | ||
| const number = Number(_input); |
There was a problem hiding this comment.
Add these user-visible error-dismissal, question-selection, and footer changes to the root CHAGELOG.md under Unreleased, including the proposed PR link; this commit changes interactive behavior without the release-history entry required for every PR.
AGENTS.md reference: AGENTS.md:L3-L8
Useful? React with 👍 / 👎.
| useInput( | ||
| (_input, key) => { | ||
| if (key.escape) onDismiss?.(); | ||
| }, | ||
| { isActive: onDismiss !== undefined }, |
There was a problem hiding this comment.
When a server error is displayed while runState is still streaming, pressing the advertised Escape key invokes this handler and the non-modal global handler, whose streaming Escape path calls onInterrupt; in transcript mode it also exits the transcript. Thus following the new dismissal hint can unexpectedly pause the live run or navigate away. Give error dismissal priority in the global keybinding flow or otherwise suppress the conflicting handler.
Useful? React with 👍 / 👎.
| if (Number.isInteger(number) && number >= 1 && number <= options.length) { | ||
| const next = number - 1; | ||
| if (allowOther && next === otherIndex) { |
There was a problem hiding this comment.
When allowOther is true, the rendered Other entry is numbered options.length + 1, but this guard only accepts numbers through options.length. Consequently next === otherIndex is unreachable, so pressing the displayed number for Other does nothing instead of opening the text input as intended.
Useful? React with 👍 / 👎.
…ooter, UI cleanup - ErrorMessage accepts onDismiss (esc) with an 'esc to dismiss' hint; useAgent exposes clearError and both render sites pass it through. - QuestionPicker accepts 1..n number keys for quick selection (single select submits, multi-select toggles, Other opens the input). - Blue footer renders only while monitoring is connected or unread notifications exist, instead of every session. - Remove dead code: SessionPicker (141 lines, unreferenced) and SpinnerIcon (unused). - Blue notification templates use English to match the rest of the TUI (per-run agent language remains server-controlled). Deferred from #1034 as needing design: one-shot auto-reconnect with a 'Reconnecting…' indicator, and transcript-mode interactivity (scroll / slash input). Pure Ink primitives — cross-platform (macOS/Linux/WSL2/ Windows). Partially addresses #1034
The first i18n pass had not persisted (working-tree translation lost across branch switches) — this re-applies and verifies the templates are Korean-free, and updates the blue notification tests to the English templates. threadStore failures in the full suite are pre-existing (pass standalone). Partially addresses #1034
b9ec66c to
8d70472
Compare
# Conflicts: # clients/cli/src/screens/REPL.tsx
The quick-number range check stopped at options.length, so the numbered Other entry (options.length + 1) could only be selected with the arrow keys and the number branch for it was dead code. Gate on totalEntries instead; add regression tests for number submit, Other-by-number, and numbers past the last entry.
# Conflicts: # CHAGELOG.md
Partially addresses #1034
What
1–nnumber keys (single-select submits, multi-select toggles, Other opens the input) — the list was already numbered.Deliberately deferred (needs design; happy to follow up)
Compatibility
Pure Ink/React primitives only — no platform-specific behavior (macOS / Linux / WSL2 / Windows terminals).
Verification
tsc --noEmitcleanImplementation commit: ed5baa4