fix: add npcs.json and objs.json seed data with build validation

[xusuxiang8]

Closes #83 and #84

Changes

• Added api/src/jsons/npcs.json - NPC seed data extracted from game DB
• Added api/src/jsons/objs.json - Item/object definitions seed data
• Updated build script: explicit file validation before copy instead of wildcard cp
• Build now fails early if any critical JSON seed file is missing

Root Cause

Both issues (#83 market test, #84 wiki endpoint) failed because
the CI build was missing npcs.json in api/src/jsons/. The wildcard
cp src/jsons/*.json silently skipped missing files.

Verification

• All 67 tests pass locally
• Build script validates 6 required JSON files before copying

[gitar-bot]

💡 Quality: Build whitelist silently drops non-listed jsons/*.json files

The build was changed from cp src/jsons/*.json to an explicit list of 6 files, and each filename now appears twice (in the test -f guard and the cp argument). Any future or generated JSON seed file that is not added to both places will silently be excluded from dist/jsons/. Notably gameData.ts prefers objs.compact.json/npcs.compact.json when present via resolveSeedJsonPath; if those compact variants are ever generated into src/jsons, the old wildcard would have copied them but this new list will not, silently falling back to the full files. Consider keeping the wildcard copy (cp src/jsons/*.json dist/jsons/) for the copy step while retaining the explicit test -f checks only for the required files, so validation stays strict but no file is dropped.

_{Was this helpful? React with 👍 / 👎}

[gitar-bot]

Code Review 👍 Approved with suggestions 0 resolved / 1 findings

Adds npcs.json and objs.json seed data alongside strict build validation to prevent missing file failures. Consider adjusting the build whitelist to avoid silently dropping non-listed JSON files.

💡 Quality: Build whitelist silently drops non-listed jsons/*.json files

📄 api/package.json:25

The build was changed from cp src/jsons/*.json to an explicit list of 6 files, and each filename now appears twice (in the test -f guard and the cp argument). Any future or generated JSON seed file that is not added to both places will silently be excluded from dist/jsons/. Notably gameData.ts prefers objs.compact.json/npcs.compact.json when present via resolveSeedJsonPath; if those compact variants are ever generated into src/jsons, the old wildcard would have copied them but this new list will not, silently falling back to the full files. Consider keeping the wildcard copy (cp src/jsons/*.json dist/jsons/) for the copy step while retaining the explicit test -f checks only for the required files, so validation stays strict but no file is dropped.

🤖 Prompt for agents

Code Review: Adds npcs.json and objs.json seed data alongside strict build validation to prevent missing file failures. Consider adjusting the build whitelist to avoid silently dropping non-listed JSON files.

1. 💡 Quality: Build whitelist silently drops non-listed jsons/*.json files
   Files: api/package.json:25

   The build was changed from `cp src/jsons/*.json` to an explicit list of 6 files, and each filename now appears twice (in the `test -f` guard and the `cp` argument). Any future or generated JSON seed file that is not added to both places will silently be excluded from `dist/jsons/`. Notably `gameData.ts` prefers `objs.compact.json`/`npcs.compact.json` when present via `resolveSeedJsonPath`; if those compact variants are ever generated into `src/jsons`, the old wildcard would have copied them but this new list will not, silently falling back to the full files. Consider keeping the wildcard copy (`cp src/jsons/*.json dist/jsons/`) for the copy step while retaining the explicit `test -f` checks only for the required files, so validation stays strict but no file is dropped.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}